Page MenuHomePhabricator

[cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake
AbandonedPublic

Authored by mgorny on Oct 17 2016, 1:11 AM.

Details

Reviewers
krytarowski
beanz
Summary

Use LLVM_CMAKE_PATH to spawn GetSVN.cmake rather than the source path
when stand-alone build is performed, to remove the unnecessary
dependency on LLVM sources and use the installed version instead.
Non-standalone builds retain the old behavior.

Diff Detail

Event Timeline

mgorny updated this revision to Diff 74817.Oct 17 2016, 1:11 AM
mgorny retitled this revision from to [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake.
mgorny updated this object.
mgorny added reviewers: beanz, krytarowski.
mgorny added a subscriber: lldb-commits.
beanz edited edge metadata.Oct 17 2016, 9:00 PM

Maybe we should define LLVM_CMAKE_PATH in llvm's CMakeLists.txt so that we don't need a condition here or in clang where we do the same thing?

krytarowski edited edge metadata.Oct 17 2016, 9:17 PM

This change makes sense for stand-alone builds, but if it's possible to remove branching in this CMake file - please go for it.

mgorny planned changes to this revision.Oct 18 2016, 5:47 AM

LLVM_CMAKE_PATH posted as D25724.

mgorny abandoned this revision.Oct 19 2016, 5:44 AM

Now handled as a followup of D25724.