This is an archive of the discontinued LLVM Phabricator instance.

[Sema] Handle CaseStmt and DefaultStmt as SwitchCase
ClosedPublic

Authored by vitalybuka on Oct 16 2016, 10:05 PM.

Reviewers

Commits

Summary

rsmith

Build Status

Buildable 519
Build 519: arc lint + arc unit

vitalybuka retitled this revision from to [Sema] Handle CaseStmt and DefaultStmt as SwitchCase.

vitalybuka updated this object.

It's fine to commit obvious cleanups like this with post-commit review.

This revision is now accepted and ready to land.Oct 25 2016, 5:18 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Sema/

6 lines

Show First 20 Lines • Show All 544 Lines • ▼ Show 20 Lines	if (StmtsToSkip) {
continue;		continue;
}		}

// Cases, labels, and defaults aren't "scope parents". It's also		// Cases, labels, and defaults aren't "scope parents". It's also
// important to handle these iteratively instead of recursively in		// important to handle these iteratively instead of recursively in
// order to avoid blowing out the stack.		// order to avoid blowing out the stack.
while (true) {		while (true) {
Stmt *Next;		Stmt *Next;
if (CaseStmt *CS = dyn_cast<CaseStmt>(SubStmt))		if (SwitchCase *SC = dyn_cast<SwitchCase>(SubStmt))
Next = CS->getSubStmt();		Next = SC->getSubStmt();
else if (DefaultStmt *DS = dyn_cast<DefaultStmt>(SubStmt))
Next = DS->getSubStmt();
else if (LabelStmt *LS = dyn_cast<LabelStmt>(SubStmt))		else if (LabelStmt *LS = dyn_cast<LabelStmt>(SubStmt))
Next = LS->getSubStmt();		Next = LS->getSubStmt();
else		else
break;		break;

LabelAndGotoScopes[SubStmt] = ParentScope;		LabelAndGotoScopes[SubStmt] = ParentScope;
SubStmt = Next;		SubStmt = Next;
}		}
▲ Show 20 Lines • Show All 342 Lines • Show Last 20 Lines