This is an archive of the discontinued LLVM Phabricator instance.

Timer: Remove group-less NamedRegionTimer constructor
ClosedPublic

Authored by MatzeB on Oct 13 2016, 4:09 PM.

Details

Summary

The NamedRegionTimer initializer without a group name puts the Timer
into the "Misc" group but appears to be (mostly) unused. Remove it.

The only user of this constructor appears to be the HexagonGenInsert pass,
which creates a counter without group to count the complete execution
time of that pass, however since every pass gets a counter by the
PassManager anyway this should be unnecessary. Also removed the
pointless TimerGroup there.

(I am removing this code now because it will slightly simplify an upcoming patch of mine)

Diff Detail

Repository
rL LLVM

Event Timeline

MatzeB updated this revision to Diff 74593.Oct 13 2016, 4:09 PM
MatzeB retitled this revision from to Timer: Remove group-less NamedRegionTimer constructor.
MatzeB updated this object.
MatzeB added a reviewer: kparzysz.
MatzeB set the repository for this revision to rL LLVM.
MatzeB added a subscriber: llvm-commits.

For the record: I did not find any uses in clang, lldb and swift either.

kparzysz accepted this revision.Oct 13 2016, 5:22 PM
kparzysz edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2016, 5:22 PM
This revision was automatically updated to reflect the committed changes.