This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Include <algorithm> in string_view::copy test
ClosedPublic

Authored by BillyONeal on Oct 12 2016, 12:48 PM.

Details

Summary

The string_view::copy test calls std::min, which is not required to be
made available by including <string_view>.

(The MSVC++ STL does not use std::min internally because we need to
avoid the *macro* named min which is defined by windows.h)

Diff Detail

Event Timeline

BillyONeal retitled this revision from to [libcxx] [test] Include <algorithm> in string_view::copy test.
BillyONeal updated this object.
BillyONeal added reviewers: EricWF, mclow.lists.
BillyONeal added a subscriber: cfe-commits.
EricWF accepted this revision.Oct 12 2016, 12:49 PM
EricWF edited edge metadata.

@BillyONeal Do you have commit access?

This revision is now accepted and ready to land.Oct 12 2016, 12:49 PM

No, I don't believe any of us in MSVC++ land have commit access.

EricWF closed this revision.Oct 24 2016, 1:20 PM

r285012.