Introduce LinkAllPasses.cpp as LLVMAllPasses

[chapuni]

Summary

Motivation: http://llvm.org/bugs/show_bug.cgi?id=18407
External projects, for example dragonegg, would be affected when pass is added.

This patch introduces libLLVMAllPasses.a in lib/Transforms.

Even without LLVM_LINKALLPASSES_IFACE, everything would work fine.
I introduce LLVM_LINKALLPASSES_IFACE to make inter-object dependency scaning easier.

I expect clang can be built regardless of this patch.

[chandlerc]

I would really like to avoid this.

I'm quite optimistic about the need fir LinkAllPasses and other hacks like
that to make the existing registration system work going away with the new
pass manager.

Why is the correct fix not to add a dependency from dragonegg -> objcarc?

[chapuni]

Although it'd be one of possible fixes, at least in trunk, to add objcarc to dragonegg, ...

Are you really planning to deprecate the way of "show all available paths" and to let us update each transforms client (opt, bugpoint, &c) whenever passes are added/removed?
Or do you have alternates? I could abandon this patch then.

[chandlerc]

This seems dead, and the alternative "passes" library is in the tree now for the new pass manager.

llvm/include/llvm/LinkAllPasses.h

 #include "llvm/Transforms/IPO.h"
 #include "llvm/Transforms/Instrumentation.h"
 #include "llvm/Transforms/ObjCARC.h"
 #include "llvm/Transforms/Scalar.h"
 #include "llvm/Transforms/Utils/UnifyFunctionExitNodes.h"
 #include "llvm/Transforms/Vectorize.h"
 #include <cstdlib>
 
+namespace llvm {
+  extern void initializeAllPasses(PassRegistry &Registry);
+}
+
+// LLVM_LINKALLPASSES_IFACE suppresses redundant individual passes.
+// LinkAllPasses.cpp has them.
+
+#if !defined(LLVM_LINKALLPASSES_IFACE)
 namespace {
   struct ForcePassLinking {
     ForcePassLinking() {
       // We must reference the passes in such a way that compilers will not
       // delete it all as dead code, even with whole program optimization,
       // yet is effectively a NO-OP. As the compiler isn't smart enough
       // to know that getenv() never returns -1, this will do the job.
       if (std::getenv("bar") != (char*) -1)
ForcePassLinking() {
       ((llvm::Function*)0)->viewCFGOnly();
       llvm::RGPassManager RGM;
       ((llvm::RegionPass*)0)->runOnRegion((llvm::Region*)0, RGM);
       llvm::AliasSetTracker X(*(llvm::AliasAnalysis*)0);
       X.add((llvm::Value*)0, 0, 0);  // for -print-alias-sets
     }
   } ForcePassLinking; // Force link by creating a global definition.
 }
+#endif
 
 #endif

llvm/lib/Transforms/CMakeLists.txt

+add_llvm_library(LLVMAllPasses
+  LinkAllPasses.cpp
+  )
+
 add_subdirectory(Utils)
 add_subdirectory(Instrumentation)
 add_subdirectory(InstCombine)
 add_subdirectory(Scalar)
 add_subdirectory(IPO)
 add_subdirectory(Vectorize)
 add_subdirectory(Hello)
 add_subdirectory(ObjCARC)

llvm/lib/Transforms/LLVMBuild.txt

 
 [common]
 subdirectories = IPO InstCombine Instrumentation Scalar Utils Vectorize ObjCARC
 
 [component_0]
 type = Group
 name = Transforms
 parent = Libraries
+
+; It should correspond to LinkAllPasses.h.
+[component_1]
+type = Library
+name = AllPasses
+parent = Libraries
+required_libraries = Analysis Core Instrumentation IPA IPO ObjCARC Scalar InstCombine TransformUtils Target Vectorize

llvm/lib/Transforms/LinkAllPasses.cpp

+//===-- LinkAllPasses.cpp -------------------------------------------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// This file references all known passes.
+//
+//===----------------------------------------------------------------------===//
+
+#include "llvm/LinkAllPasses.h"
+
+using namespace llvm;
+
+void llvm::initializeAllPasses(PassRegistry &Registry) {
+  initializeCore(Registry);
+  initializeDebugIRPass(Registry);
+  initializeScalarOpts(Registry);
+  initializeObjCARCOpts(Registry);
+  initializeVectorization(Registry);
+  initializeIPO(Registry);
+  initializeAnalysis(Registry);
+  initializeIPA(Registry);
+  initializeTransformUtils(Registry);
+  initializeInstCombine(Registry);
+  initializeInstrumentation(Registry);
+  initializeTarget(Registry);
+}

llvm/lib/Transforms/Makefile

 ##===- lib/Transforms/Makefile -----------------------------*- Makefile -*-===##
 #
 #                     The LLVM Compiler Infrastructure
 #
 # This file is distributed under the University of Illinois Open Source
 # License. See LICENSE.TXT for details.
 #
 ##===----------------------------------------------------------------------===##
 
 LEVEL = ../..
+LIBRARYNAME = LLVMAllPasses
+BUILD_ARCHIVE = 1
 PARALLEL_DIRS = Utils Instrumentation Scalar InstCombine IPO Vectorize Hello ObjCARC
 
 include $(LEVEL)/Makefile.config
 
 # No support for plugins on windows targets
 ifeq ($(HOST_OS), $(filter $(HOST_OS), Cygwin MingW Minix))
   PARALLEL_DIRS := $(filter-out Hello, $(PARALLEL_DIRS))
 endif
 
 include $(LEVEL)/Makefile.common

llvm/tools/bugpoint/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
-  Analysis
+  AllPasses
   BitWriter
   Core
-  IPA
   IPO
   IRReader
-  InstCombine
-  Instrumentation
   Linker
-  ObjCARCOpts
-  ScalarOpts
   Support
-  Target
   TransformUtils
-  Vectorize
   )
 
 # Support plugins.
 set(LLVM_NO_DEAD_STRIP 1)
 
 add_llvm_tool(bugpoint
   BugDriver.cpp
   CrashDebugger.cpp

llvm/tools/bugpoint/Makefile

 ##===- tools/bugpoint/Makefile -----------------------------*- Makefile -*-===##
 # 
 #                     The LLVM Compiler Infrastructure
 #
 # This file is distributed under the University of Illinois Open Source
 # License. See LICENSE.TXT for details.
 # 
 ##===----------------------------------------------------------------------===##
 
 LEVEL := ../..
 TOOLNAME := bugpoint
-LINK_COMPONENTS := asmparser instrumentation scalaropts ipo linker bitreader \
-                   bitwriter irreader vectorize objcarcopts
+LINK_COMPONENTS := allpasses bitwriter core ipo irreader linker \
+                   support transformutils
+
 
 # Support plugins.
 NO_DEAD_STRIP := 1
 
 include $(LEVEL)/Makefile.common

llvm/tools/bugpoint/bugpoint.cpp

 //===- bugpoint.cpp - The LLVM Bugpoint utility ---------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This program is an automated compiler debugger tool.  It is used to narrow
 // down miscompilations and crash problems to a specific pass in the compiler,
 // and the specific Module or Function input that is causing the problem.
 //
 //===----------------------------------------------------------------------===//
 
+#define LLVM_LINKALLPASSES_IFACE
+
 #include "BugDriver.h"
 #include "ToolRunner.h"
 #include "llvm/IR/LLVMContext.h"
 #include "llvm/LinkAllIR.h"
 #include "llvm/LinkAllPasses.h"
 #include "llvm/PassManager.h"
 #include "llvm/Support/CommandLine.h"
 #include "llvm/Support/ManagedStatic.h"

 #ifndef DEBUG_BUGPOINT
   llvm::sys::PrintStackTraceOnErrorSignal();
   llvm::PrettyStackTraceProgram X(argc, argv);
   llvm_shutdown_obj Y;  // Call llvm_shutdown() on exit.
 #endif
 
   // Initialize passes
   PassRegistry &Registry = *PassRegistry::getPassRegistry();
-  initializeCore(Registry);
-  initializeScalarOpts(Registry);
-  initializeObjCARCOpts(Registry);
-  initializeVectorization(Registry);
-  initializeIPO(Registry);
-  initializeAnalysis(Registry);
-  initializeIPA(Registry);
-  initializeTransformUtils(Registry);
-  initializeInstCombine(Registry);
-  initializeInstrumentation(Registry);
-  initializeTarget(Registry);
+  initializeAllPasses(Registry);
 
   cl::ParseCommandLineOptions(argc, argv,
                               "LLVM automatic testcase reducer. See\nhttp://"
                               "llvm.org/cmds/bugpoint.html"
                               " for more information.\n");
 #ifndef DEBUG_BUGPOINT
   sys::SetInterruptFunction(BugpointInterruptFunction);
 #endif

llvm/tools/opt/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   ${LLVM_TARGETS_TO_BUILD}
+  AllPasses
   Analysis
   BitWriter
   Core
   IPA
   IPO
   IRReader
-  InstCombine
-  Instrumentation
   MC
-  ObjCARCOpts
-  ScalarOpts
   Support
-  Target
-  TransformUtils
-  Vectorize
   )
 
 # Support plugins.
 set(LLVM_NO_DEAD_STRIP 1)
 
 add_llvm_tool(opt
   AnalysisWrappers.cpp
   GraphPrinters.cpp
   NewPMDriver.cpp
   Passes.cpp
   PrintSCC.cpp
   opt.cpp
   )
 set_target_properties(opt PROPERTIES ENABLE_EXPORTS 1)

llvm/tools/opt/Makefile

 ##===- tools/opt/Makefile ----------------------------------*- Makefile -*-===##
 #
 #                     The LLVM Compiler Infrastructure
 #
 # This file is distributed under the University of Illinois Open Source
 # License. See LICENSE.TXT for details.
 #
 ##===----------------------------------------------------------------------===##
 
 LEVEL := ../..
 TOOLNAME := opt
-LINK_COMPONENTS := bitreader bitwriter asmparser irreader instrumentation scalaropts objcarcopts ipo vectorize all-targets
+LINK_COMPONENTS := allpasses analysis bitwriter core ipa ipo irreader mc \
+                   support all-targets
 
 # Support plugins.
 NO_DEAD_STRIP := 1
 
 include $(LEVEL)/Makefile.common

llvm/tools/opt/opt.cpp

 //===- opt.cpp - The LLVM Modular Optimizer -------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // Optimizations may be specified an arbitrary number of times on the command
 // line, They are run in the order specified.
 //
 //===----------------------------------------------------------------------===//
 
+#define LLVM_LINKALLPASSES_IFACE
+
 #include "NewPMDriver.h"
 #include "llvm/ADT/StringSet.h"
 #include "llvm/ADT/Triple.h"
 #include "llvm/Analysis/CallGraph.h"
 #include "llvm/Analysis/CallGraphSCCPass.h"
 #include "llvm/Analysis/LoopPass.h"
 #include "llvm/Analysis/RegionPass.h"
 #include "llvm/Bitcode/BitcodeWriterPass.h"
int main(int argc, char **argv) {
   llvm_shutdown_obj Y;  // Call llvm_shutdown() on exit.
   LLVMContext &Context = getGlobalContext();
 
   InitializeAllTargets();
   InitializeAllTargetMCs();
 
   // Initialize passes
   PassRegistry &Registry = *PassRegistry::getPassRegistry();
-  initializeCore(Registry);
-  initializeDebugIRPass(Registry);
-  initializeScalarOpts(Registry);
-  initializeObjCARCOpts(Registry);
-  initializeVectorization(Registry);
-  initializeIPO(Registry);
-  initializeAnalysis(Registry);
-  initializeIPA(Registry);
-  initializeTransformUtils(Registry);
-  initializeInstCombine(Registry);
-  initializeInstrumentation(Registry);
-  initializeTarget(Registry);
+  initializeAllPasses(Registry);
 
   cl::ParseCommandLineOptions(argc, argv,
     "llvm .bc -> .bc modular optimizer and analysis printer\n");
 
   if (AnalyzeOnly && NoOutput) {
     errs() << argv[0] << ": analyze mode conflicts with no-output mode.\n";
     return 1;
   }