This is an archive of the discontinued LLVM Phabricator instance.

Fix test suite lookup path for LLDB.h
ClosedPublic

Authored by beanz on Oct 11 2016, 2:09 PM.

Details

Summary

When running on Darwin, the test suite assumes a specific directory structure for the build directory. This works for the Xcode project builds, but fails for CMake builds regardless of whether or not you are generating the LLDB framework.

This patch allows the Darwin code path to fall back to the more generic code path used by other platforms in the event that LLDB.h isn't where the test suite expects it.

This allows API tests to run on Darwin when building with CMake with the framework build enabled or disabled.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 74294.Oct 11 2016, 2:09 PM
beanz retitled this revision from to Fix test suite lookup path for LLDB.h.
beanz updated this object.
beanz added reviewers: tfiala, zturner.
beanz added a subscriber: lldb-commits.
zturner accepted this revision.Oct 11 2016, 3:56 PM
zturner edited edge metadata.
This revision is now accepted and ready to land.Oct 11 2016, 3:56 PM
labath added a subscriber: labath.Oct 12 2016, 2:03 AM

Our darwin buildbot is also running the local test suite with cmake: http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4, look under build step "test9 local test". We've been considering turning these tests off as we don't have bandwidth to monitor and fix them, but if you find them helpful, we can certainly keep them running.

beanz added a comment.Oct 12 2016, 1:30 PM

@labath I think having them running is useful. At the moment that is probably the only Darwin bot building LLDB using CMake.

This revision was automatically updated to reflect the committed changes.
tfiala edited edge metadata.Oct 13 2016, 9:30 AM

(Retro) LGTM.