This is an archive of the discontinued LLVM Phabricator instance.

Use `let' instead of `let' in one place where `let' isn't necessary
ClosedPublic

Authored by phst on Oct 8 2016, 5:35 AM.

Download Raw Diff

Details

Reviewers

Commits

rG5f850483853c: Use `let' instead of `let*' in one place where `let*' isn't necessary
rCTE283736: Use `let' instead of `let*' in one place where `let*' isn't necessary

Diff Detail

Event Timeline

phst updated this revision to Diff 74021.Oct 8 2016, 5:35 AM

phst retitled this revision from to Use `let' instead of `let*' in one place where `let*' isn't necessary.

phst updated this object.

phst added a reviewer: klimek.

phst added a project: Restricted Project.

This revision is now accepted and ready to land.Oct 10 2016, 2:52 AM

Committed in rL283736.

Revision Contents

Path

Size

include-fixer/

tool/

clang-include-fixer.el

6 lines

Diff 74021

include-fixer/tool/clang-include-fixer.el

Show First 20 Lines • Show All 88 Lines • ▼ Show 20 Lines	buffer as only argument."
nil)		nil)

(defun clang-include-fixer--make-process (callback args)		(defun clang-include-fixer--make-process (callback args)
"Start a new clang-incude-fixer process using `make-process'.		"Start a new clang-incude-fixer process using `make-process'.
CALLBACK is called after the process finishes successfully; it is		CALLBACK is called after the process finishes successfully; it is
called with a single argument, the buffer where standard output		called with a single argument, the buffer where standard output
has been inserted. ARGS is a list of additional command line		has been inserted. ARGS is a list of additional command line
arguments. Return the new process object."		arguments. Return the new process object."
(let* ((stdin (current-buffer))		(let ((stdin (current-buffer))
(stdout (generate-new-buffer "clang-include-fixer output"))		(stdout (generate-new-buffer "clang-include-fixer output"))
(stderr (generate-new-buffer "clang-include-fixer errors")))		(stderr (generate-new-buffer "clang-include-fixer errors")))
(make-process :name "clang-include-fixer"		(make-process :name "clang-include-fixer"
:buffer stdout		:buffer stdout
:command (clang-include-fixer--command args)		:command (clang-include-fixer--command args)
:coding 'utf-8-unix		:coding 'utf-8-unix
:connection-type 'pipe		:connection-type 'pipe
:sentinel (clang-include-fixer--sentinel stdin stdout stderr		:sentinel (clang-include-fixer--sentinel stdin stdout stderr
callback)		callback)
:stderr stderr)))		:stderr stderr)))
▲ Show 20 Lines • Show All 299 Lines • Show Last 20 Lines