This is an archive of the discontinued LLVM Phabricator instance.

[RS4GC] Handle ShuffleVector instruction in findBasePointer
ClosedPublic

Authored by anna on Oct 3 2016, 10:22 AM.

Details

Summary

This patch modifies the findBasePointer to handle the shufflevector instruction.

Tests run: RS4GC tests, local downstream tests.

Event Timeline

anna updated this revision to Diff 73300.Oct 3 2016, 10:22 AM
anna retitled this revision from to [RS4GC] Handle ShuffleVector instruction in findBasePointer.
anna updated this object.
anna added reviewers: reames, sanjoy.
anna added a subscriber: llvm-commits.
reames accepted this revision.Oct 3 2016, 12:29 PM
reames edited edge metadata.

LGTM w/changes applied.

lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
874

per lang ref, these should be the same type and thus the same value.

test/Transforms/RewriteStatepointsForGC/base-vector.ll
169

Add a test case which merges two distinct base values (i.e. arguments).

This revision is now accepted and ready to land.Oct 3 2016, 12:29 PM
This revision was automatically updated to reflect the committed changes.
anna marked 2 inline comments as done.Oct 4 2016, 6:58 AM
anna added inline comments.
test/Transforms/RewriteStatepointsForGC/base-vector.ll
169

Added test case with vector operand of shuffle vector being a phi with distinct bases.