This is an archive of the discontinued LLVM Phabricator instance.

Differential D25167

Fix regex in lldb lit test TestCallStopAndContinue
ClosedPublic

Authored by penryu on Oct 2 2016, 4:36 PM.

Details

Reviewers
beanz
• joker-eph-DISABLED
Summary

The only reason the regex failed to match for me was that the FileCheck regex enforced a space (0x20) before the dividing comma. Without knowing what else the "{{.*}}" was designed to match, this trivial diff should allow my successful output to match the expected output.

Diff Detail

Repository
rL LLVM

Event Timeline

penryu updated this revision to Diff 73223.Oct 2 2016, 4:36 PM
penryu retitled this revision from to Patch lldb lit test TestCallStopAndContinue.
penryu updated this object.
penryu added reviewers: • joker-eph-DISABLED, beanz.
penryu set the repository for this revision to rL LLVM.
penryu added a project: Restricted Project.
penryu retitled this revision from Patch lldb lit test TestCallStopAndContinue to Fix regex in lldb lit test TestCallStopAndContinue.Oct 2 2016, 4:54 PM
beanz accepted this revision.Oct 2 2016, 5:01 PM
beanz edited edge metadata.

LGTM. Thanks Tim!

This revision is now accepted and ready to land.Oct 2 2016, 5:02 PM
penryu added a comment.Oct 2 2016, 6:12 PM

r283082

Eugene.Zelenko closed this revision.Oct 4 2016, 1:24 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in rL283082.

Revision Contents

PathSize
lit/
Expr/
2 lines

Diff 73223

lit/Expr/TestCallStopAndContinue.test

Context not available.
expression -i false -- returnsFive() expression -i false -- returnsFive()
# CHECK: Execution was interrupted, reason: breakpoint # CHECK: Execution was interrupted, reason: breakpoint
# CHECK: stop reason = User Expression thread plan # CHECK: stop reason = User Expression thread plan
# CHECK: Completed expression: (Five) $0 = (number = 5 {{.*}}, name = "five") # CHECK: Completed expression: (Five) $0 = (number = 5{{.*}}, name = "five")
Context not available.