Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
change-namespace/ChangeNamespace.cpp | ||
---|---|---|
176 ↗ | (On Diff #73116) | Mightbe add a small doc saying NsName is a global namespace if it is empty. (If I misunderstand the code). |
187 ↗ | (On Diff #73116) | I think the statement doesn't compile here, since consume_front return a bool. It should be if (DeclName.consume_front((NsName + "::")))? Looks like we can also put this judge into the above while statement? |
Comment Actions
- Address review comments.
change-namespace/ChangeNamespace.cpp | ||
---|---|---|
187 ↗ | (On Diff #73116) | Note that str() is called on (NsName + "::") instead of consume_front. But you are right, we can put the check into the while loop. |
Comment Actions
LGTM.
change-namespace/ChangeNamespace.cpp | ||
---|---|---|
187 ↗ | (On Diff #73116) | Oh, I see. Sorry for misreading the code. |