This is an archive of the discontinued LLVM Phabricator instance.

[ASTMatchers] Let registerMatcher() take a const char * instead of a StringRef
AbandonedPublic

Authored by mboehme on Sep 27 2016, 6:53 AM.

Details

Reviewers
klimek
Summary

r282433 added LLVM_ATTRIBUTE_ALWAYS_INLINE to the StringRef(const char *)
constructor. This causes the size of the stack frame for
RegistryMaps::RegistryMaps() to become excessive when compiling with gcc. This
change avoids inlining the StringRef constructor for every REGISTER_MATCHER
line.

Diff Detail

Event Timeline

mboehme updated this revision to Diff 72647.Sep 27 2016, 6:53 AM
mboehme retitled this revision from to [ASTMatchers] Let registerMatcher() take a const char * instead of a StringRef.
mboehme updated this object.
mboehme added a reviewer: klimek.
mboehme added a subscriber: cfe-commits.
mboehme abandoned this revision.Sep 27 2016, 7:14 AM

Abandoning after discussion with klimek.