Page MenuHomePhabricator

libclc: Remove copyright headers from top of files
Needs ReviewPublic

Authored by tstellarAMD on Sep 26 2016, 10:14 AM.

Details

Reviewers
awatry
lattner
Summary

This is to comply with LLVM project policy. For any license header that mentioned a specific copyright owner, the owner has been added to to CREDITS.txt.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to libclc: Remove copyright headers from top of files.
tstellarAMD updated this object.
tstellarAMD added reviewers: lattner, awatry.
lattner edited edge metadata.Sep 26 2016, 2:45 PM

Looks reasonable, please add the standard LLVM file header blob per the coding standards.

awatry requested changes to this revision.Sep 26 2016, 6:55 PM
awatry edited edge metadata.

See my comment for gen_convert.py. I think we're accidentally deleting more than we mean to.

generic/lib/gen_convert.py
28

Did you mean to remove this part of the script's header comment?

This revision now requires changes to proceed.Sep 26 2016, 6:55 PM
tstellarAMD edited edge metadata.

Fix gen_convert.py and add LLVM file headers to all files.

awatry requested changes to this revision.Feb 1 2017, 2:49 PM

I've gotten to the point of hitting a build error due to the addition/removal of BitcodeReader.h at some point since the last time I built llvm on this machine.

In general

  1. we need to make sure that the she-bangs in python scripts don't get moved down from the first line in the file.
  2. The comment format in python files isn't //, it's #
  3. The llvm assembly (*.ll) comment format is also wrong
  4. The SOURCES files are treated as literal lists of files, and the copyright statement in them is breaking metabuild.py. Either remove the copyright header from those files, or fix metabuild to ignore lines starting with a chosen comment character(s).
amdgcn-amdhsa/lib/SOURCES
1 ↗(On Diff #86411)

build/metabuild.py errors out here... It treats all lines in the SOURCES files as entries and tries to make directories for anything it thinks needs a parent directory...

amdgcn/lib/SOURCES
1 ↗(On Diff #86411)

build/metabuild.py errors out here... It treats all lines in the SOURCES files as entries and tries to make directories for anything it thinks needs a parent directory...

amdgpu/lib/SOURCES
1 ↗(On Diff #86411)

build/metabuild.py errors out here... It treats all lines in the SOURCES files as entries and tries to make directories for anything it thinks needs a parent directory...

build/metabuild.py
2

This isn't valid python syntax anymore. Prefix the license lines with '#'.

build/ninja_syntax.py
2

This isn't valid python syntax anymore. Prefix the license lines with '#'.

Also, you've moved the shebang down from the first line in the file, which means that this ends up getting treated as a shell script instead of python.

configure.py
2

This isn't valid python syntax anymore. Prefix the license lines with '#'.

Also, you've moved the shebang down from the first line in the file, which means that this ends up getting treated as a shell script instead of python.

generic/lib/SOURCES
1 ↗(On Diff #86411)

build/metabuild.py errors out here... It treats all lines in the SOURCES files as entries and tries to make directories for anything it thinks needs a parent directory...

generic/lib/atomic/atomic_impl.ll
2

Wrong comment-format for .ll files.

generic/lib/gen_convert.py
-32

Wrong comment format for python files.

The shebang also moved down from the first line, but it seems like the way we invoke this script as part of the build already picked a python executable, so it doesn't matter..

fwiw, this script can't be executed on its own anymore using ./gen_convert.py

generic/lib/integer/add_sat_impl.ll
2

Wrong comment format for .ll files.

generic/lib/integer/clz_if.ll
2

Wrong comment format for .ll files.

generic/lib/integer/clz_impl.ll
2

Wrong comment format for .ll files.

generic/lib/integer/sub_sat_impl.ll
2

Wrong comment format for .ll files.

generic/lib/shared/vstore_half_helpers.ll
2

Wrong comment format for .ll files.

generic/lib/subnormal_disable.ll
2

Wrong comment format for .ll files.

generic/lib/subnormal_use_default.ll
2

Wrong comment format for .ll files. Use a semi-colon at the start of the line.

ptx-nvidiacl/lib/SOURCES
1 ↗(On Diff #86411)

build/metabuild.py errors out here... It treats all lines in the SOURCES files as entries and tries to make directories for anything it thinks needs a parent directory...

ptx/lib/SOURCES
1

build/metabuild.py errors out here... It treats all lines in the SOURCES files as entries and tries to make directories for anything it thinks needs a parent directory...

ptx/lib/integer/add_sat.ll
2

Wrong comment format for .ll files. Use semi-colon at beginning of the line.

ptx/lib/integer/sub_sat.ll
2

Wrong comment format for .ll files

r600/lib/SOURCES
1 ↗(On Diff #86411)

build/metabuild.py errors out here... It treats all lines in the SOURCES files as entries and tries to make directories for anything it thinks needs a parent directory...

This revision now requires changes to proceed.Feb 1 2017, 2:49 PM
tstellarAMD edited edge metadata.

Add some build fixes from awatry.

tstellarAMD marked 15 inline comments as done.Feb 2 2017, 9:57 AM