This is an archive of the discontinued LLVM Phabricator instance.

[profile] Hide lprofCurFilename
ClosedPublic

Authored by vsk on Sep 23 2016, 1:58 PM.

Details

Summary

Apple has a build verification step which complains when external symbols are introduced into a project, if they're not defined in some header. When building programs for profiling we need to expose VPMergeHook, _llvm_profile_filename, and __llvm_profile_raw_version so we've whitelisted these. I don't think we need to expose lprofCurFilename.

Diff Detail

Repository
rL LLVM

Event Timeline

vsk updated this revision to Diff 72353.Sep 23 2016, 1:58 PM
vsk retitled this revision from to [profile] Hide lprofCurFilename.
vsk updated this object.
vsk added a reviewer: davidxl.
vsk added a subscriber: llvm-commits.
davidxl accepted this revision.Sep 23 2016, 2:00 PM
davidxl edited edge metadata.

lgtm

This revision is now accepted and ready to land.Sep 23 2016, 2:00 PM
This revision was automatically updated to reflect the committed changes.