This is an archive of the discontinued LLVM Phabricator instance.

Move computation past early return
ClosedPublic

Authored by hiraditya on Sep 22 2016, 1:48 PM.

Reviewers

spatel
• rafael

Commits

hiraditya retitled this revision from to Move computation past early return.

hiraditya updated this object.

hiraditya added a subscriber: llvm-commits.

LGTM.

This revision is now accepted and ready to land.Sep 23 2016, 1:54 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

IR/

5 lines

Show First 20 Lines • Show All 1,148 Lines • ▼ Show 20 Lines	void Instruction::setMetadata(StringRef Kind, MDNode *Node) {
setMetadata(getContext().getMDKindID(Kind), Node);		setMetadata(getContext().getMDKindID(Kind), Node);
}		}

MDNode *Instruction::getMetadataImpl(StringRef Kind) const {		MDNode *Instruction::getMetadataImpl(StringRef Kind) const {
return getMetadataImpl(getContext().getMDKindID(Kind));		return getMetadataImpl(getContext().getMDKindID(Kind));
}		}

void Instruction::dropUnknownNonDebugMetadata(ArrayRef<unsigned> KnownIDs) {		void Instruction::dropUnknownNonDebugMetadata(ArrayRef<unsigned> KnownIDs) {
SmallSet<unsigned, 5> KnownSet;
KnownSet.insert(KnownIDs.begin(), KnownIDs.end());

if (!hasMetadataHashEntry())		if (!hasMetadataHashEntry())
return; // Nothing to remove!		return; // Nothing to remove!

auto &InstructionMetadata = getContext().pImpl->InstructionMetadata;		auto &InstructionMetadata = getContext().pImpl->InstructionMetadata;

		SmallSet<unsigned, 4> KnownSet;
		KnownSet.insert(KnownIDs.begin(), KnownIDs.end());
if (KnownSet.empty()) {		if (KnownSet.empty()) {
// Just drop our entry at the store.		// Just drop our entry at the store.
InstructionMetadata.erase(this);		InstructionMetadata.erase(this);
setHasMetadataHashEntry(false);		setHasMetadataHashEntry(false);
return;		return;
}		}

auto &Info = InstructionMetadata[this];		auto &Info = InstructionMetadata[this];
▲ Show 20 Lines • Show All 293 Lines • Show Last 20 Lines