Use checktime when reloading vim buffer after applying clang-rename

[NewProggie]

Summary

After applying clang-rename to a vim buffer (using clang-rename.py as part of the vim integration) the buffer gets reloaded using bufdo. This solution is suboptimal, since syntax highlighting is turned off for performance reasons and never turned on, after all changes to the source file have been applied.

A better solution to this is using checktime. It is exactly designed for this kind of task and doesn't have the syntax highlighting issue.

[omtcyfz]

Sorry for a late response.

Yes, this solution is way better. Honestly I just didn't know how to achieve that; not a Vim pro here :)

Thank you very much!

LGTM.

[omtcyfz]

@NewProggie do you have commit access or do you want me to land this patch for you?

[NewProggie]

In D24791#551662, @omtcyfz wrote:

@NewProggie do you have commit access or do you want me to land this patch for you?

I don't have commit access. Please, land it for me. Glad, you've accepted my patch.

clang-tools-extra/trunk/clang-rename/tool/clang-rename.py

p = subprocess.Popen(command,
                          stdout=subprocess.PIPE,
                          stderr=subprocess.PIPE)
     stdout, stderr = p.communicate()
 
     if stderr:
         print stderr
 
     # Reload all buffers in Vim.
-    vim.command("bufdo edit")
+    vim.command("checktime")
 
 
 if __name__ == '__main__':
     main()