Page MenuHomePhabricator

Use checktime when reloading vim buffer after applying clang-rename
ClosedPublic

Authored by NewProggie on Sep 21 2016, 12:26 AM.

Details

Summary

After applying clang-rename to a vim buffer (using clang-rename.py as part of the vim integration) the buffer gets reloaded using bufdo. This solution is suboptimal, since syntax highlighting is turned off for performance reasons and never turned on, after all changes to the source file have been applied.

A better solution to this is using checktime. It is exactly designed for this kind of task and doesn't have the syntax highlighting issue.

Diff Detail

Repository
rL LLVM

Event Timeline

NewProggie retitled this revision from to Use checktime when reloading vim buffer after applying clang-rename.
NewProggie updated this object.
NewProggie added a subscriber: cfe-commits.
omtcyfz accepted this revision.Sep 24 2016, 3:18 PM
omtcyfz edited edge metadata.

Sorry for a late response.

Yes, this solution is way better. Honestly I just didn't know how to achieve that; not a Vim pro here :)

Thank you very much!

LGTM.

This revision is now accepted and ready to land.Sep 24 2016, 3:18 PM

@NewProggie do you have commit access or do you want me to land this patch for you?

@NewProggie do you have commit access or do you want me to land this patch for you?

I don't have commit access. Please, land it for me. Glad, you've accepted my patch.

This revision was automatically updated to reflect the committed changes.