This is an archive of the discontinued LLVM Phabricator instance.

X86: Do not produce GOT relocations on windows
ClosedPublic

Authored by MatzeB on Sep 15 2016, 1:54 PM.

Details

Summary

r270209 ("Refactor X86 symbol access classification.") broke some EFI firmware projects targetting x86_64-pc-windows-macho. This patch fixes that:

Windows has no GOT relocations the way elf/darwin has.
"x86_64-pc-win32-macho" is sometimes used to build EFI firmware; Use windows style reloction (no-GOT) for this target.

Diff Detail

Repository
rL LLVM

Event Timeline

MatzeB updated this revision to Diff 71549.Sep 15 2016, 1:54 PM
MatzeB retitled this revision from to X86: Do not produce GOT relocations on windows.
MatzeB updated this object.
MatzeB added a reviewer: rafael.
MatzeB set the repository for this revision to rL LLVM.
MatzeB added a subscriber: llvm-commits.
majnemer accepted this revision.Sep 15 2016, 2:47 PM
majnemer added a reviewer: majnemer.
majnemer added a subscriber: majnemer.

LGTM

This revision is now accepted and ready to land.Sep 15 2016, 2:47 PM
This revision was automatically updated to reflect the committed changes.