This is an archive of the discontinued LLVM Phabricator instance.

[Release notes] Mention readability-container-size-empty improvements
ClosedPublic

Authored by Eugene.Zelenko on Sep 13 2016, 3:34 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

Eugene.Zelenko retitled this revision from to [Release notes] Mention readability-container-size-empty improvements.
Eugene.Zelenko updated this object.
Eugene.Zelenko added reviewers: alexfh, omtcyfz.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: cfe-commits.
alexfh accepted this revision.Sep 14 2016, 1:11 AM
alexfh edited edge metadata.

LG with a nit.

docs/ReleaseNotes.rst
94 ↗(On Diff #71250)

The wording is a bit too broad. We should somehow hint that the methods are not just arbitrary. Maybe "with suitable `size() and empty()` methods"?

This revision is now accepted and ready to land.Sep 14 2016, 1:11 AM
docs/ReleaseNotes.rst
94 ↗(On Diff #71250)

Will fix on commit. Suitable sounds good enough since link to documentation is provided, where more details could be found.

This revision was automatically updated to reflect the committed changes.