This is an archive of the discontinued LLVM Phabricator instance.

Differential D24476

[CMake] Fix linker-as-ld to symlink instead of copy lld
ClosedPublic

Authored by beanz on Sep 12 2016, 2:59 PM.

Details

Reviewers
davide
llvm-commits
Commits
rG5a805df1a575: [CMake] Fix linker-as-ld to symlink instead of copy lld
rLLD281271: [CMake] Fix linker-as-ld to symlink instead of copy lld
rL281271: [CMake] Fix linker-as-ld to symlink instead of copy lld
Summary

This test fails if you're building with BUILD_SHARED_LIBS because the LLVM libraries are found via @rpath. Symlinking instead of copying should be sufficiently robust for the test case.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 71060.Sep 12 2016, 2:59 PM
beanz retitled this revision from to [CMake] Fix linker-as-ld to symlink instead of copy lld.
beanz updated this object.
beanz added a reviewer: llvm-commits.
beanz added a subscriber: davide.
davide added a comment.Sep 12 2016, 3:03 PM

Makes sense to me, thanks!

davide accepted this revision.Sep 12 2016, 3:04 PM
davide added a reviewer: davide.
This revision is now accepted and ready to land.Sep 12 2016, 3:04 PM
Closed by commit rL281271: [CMake] Fix linker-as-ld to symlink instead of copy lld (authored by cbieneman). · Explain WhySep 12 2016, 3:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
test/
mach-o/
4 lines

Diff 71068

lld/trunk/test/mach-o/linker-as-ld.yaml

# REQUIRES: system-linker-mach-o # REQUIRES: system-linker-mach-o
# #
# RUN: mkdir -p %t.dir && cp `which lld` %t.dir/ld \ # RUN: rm -rf %T/ld && ln -s `which lld` %T/ld \
# RUN: && %t.dir/ld -arch x86_64 -macosx_version_min 10.8 %s \ # RUN: && %T/ld -arch x86_64 -macosx_version_min 10.8 %s \
# RUN: %p/Inputs/linker-as-ld.yaml -o %t \ # RUN: %p/Inputs/linker-as-ld.yaml -o %t \
# RUN: && llvm-nm %t | FileCheck %s # RUN: && llvm-nm %t | FileCheck %s
# #
# Test linker run as "ld" on darwin works as darwin linker. # Test linker run as "ld" on darwin works as darwin linker.
# #
--- !mach-o --- !mach-o
arch: x86_64 arch: x86_64
Show All 20 Lines