This is an archive of the discontinued LLVM Phabricator instance.

Enable in-tree builds of parallel-libs.
ClosedPublic

Authored by jlebar on Sep 9 2016, 9:08 AM.

Details

Summary

parallel-libs needs its own changes to make this work; these are just
the LLVM changes.

Diff Detail

Repository
rL LLVM

Event Timeline

jlebar updated this revision to Diff 70847.Sep 9 2016, 9:08 AM
jlebar retitled this revision from to Enable in-tree builds of parallel-libs..
jlebar updated this object.
jlebar added a reviewer: jhen.
jlebar added subscribers: jprice, llvm-commits.
jhen accepted this revision.Sep 9 2016, 10:46 AM
jhen edited edge metadata.
This revision is now accepted and ready to land.Sep 9 2016, 10:46 AM
beanz added a comment.Sep 9 2016, 1:02 PM

If you want to support parallel-libs building with just-built toolchains you may also want to ensure that it is compatible with the LLVM runtimes subdirectory.

If the intention is that it should not be built with just-built toolchains, you probably should add this under tools rather than projects.

jlebar added a comment.Sep 9 2016, 1:03 PM

you may also want to ensure that it is compatible with the LLVM runtimes subdirectory.

Sorry, outside my depth: What do you mean?

beanz added a comment.Sep 9 2016, 1:26 PM

The LLVM runtimes directory is a new mechanism in the CMake build system for building runtime libraries. It gives in-tree workflows while using just-built toolchains.

The last update on the effort is here:
http://lists.llvm.org/pipermail/llvm-dev/2016-August/104174.html

That also contains links back to the earlier discussions.

jlebar added a comment.Sep 9 2016, 2:41 PM

All right, thanks.

We'll take a look at this, but it's a lot easier to collaborate if this is checked in, so I'm going to push it first, hope that's OK.

This revision was automatically updated to reflect the committed changes.