This is an archive of the discontinued LLVM Phabricator instance.

Differential D24286

Add MS __nop intrinsic to intrin.h
ClosedPublic

Authored by agutowski on Sep 6 2016, 5:10 PM.

Details

Reviewers
thakis
rnk
Commits
rG5de2bcdcf620: Add MS __nop intrinsic to intrin.h
rC280826: Add MS __nop intrinsic to intrin.h
rL280826: Add MS __nop intrinsic to intrin.h
Summary

There was no definition for __nop function - added inline assembly.

Diff Detail

Repository
rL LLVM

Event Timeline

agutowski updated this revision to Diff 70495.Sep 6 2016, 5:10 PM
agutowski retitled this revision from to Add MS __nop intrinsic to intrin.h.
agutowski updated this object.
agutowski added reviewers: rnk, thakis.
agutowski added a subscriber: cfe-commits.
thakis accepted this revision.Sep 7 2016, 8:05 AM
thakis edited edge metadata.

Looks great, thanks!

This revision is now accepted and ready to land.Sep 7 2016, 8:05 AM
Closed by commit rL280826: Add MS __nop intrinsic to intrin.h (authored by rnk). · Explain WhySep 7 2016, 10:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
lib/
Headers/
5 lines
test/
Headers/
1 line

Diff 70555

cfe/trunk/lib/Headers/intrin.h

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
unsigned int __lzcnt(unsigned int); unsigned int __lzcnt(unsigned int);
unsigned short __lzcnt16(unsigned short); unsigned short __lzcnt16(unsigned short);
static __inline__ static __inline__
void __movsb(unsigned char *, unsigned char const *, size_t); void __movsb(unsigned char *, unsigned char const *, size_t);
static __inline__ static __inline__
void __movsd(unsigned long *, unsigned long const *, size_t); void __movsd(unsigned long *, unsigned long const *, size_t);
static __inline__ static __inline__
void __movsw(unsigned short *, unsigned short const *, size_t); void __movsw(unsigned short *, unsigned short const *, size_t);
static __inline__
void __nop(void); void __nop(void);
void __nvreg_restore_fence(void); void __nvreg_restore_fence(void);
void __nvreg_save_fence(void); void __nvreg_save_fence(void);
void __outbyte(unsigned short, unsigned char); void __outbyte(unsigned short, unsigned char);
void __outbytestring(unsigned short, unsigned char *, unsigned long); void __outbytestring(unsigned short, unsigned char *, unsigned long);
void __outdword(unsigned short, unsigned long); void __outdword(unsigned short, unsigned long);
void __outdwordstring(unsigned short, unsigned long *, unsigned long); void __outdwordstring(unsigned short, unsigned long *, unsigned long);
void __outword(unsigned short, unsigned short); void __outword(unsigned short, unsigned short);
▲ Show 20 Lines • Show All 805 Lines • ▼ Show 20 Lines_xgetbv(unsigned int __xcr_no) {
unsigned int __eax, __edx; unsigned int __eax, __edx;
__asm__ ("xgetbv" : "=a" (__eax), "=d" (__edx) : "c" (__xcr_no)); __asm__ ("xgetbv" : "=a" (__eax), "=d" (__edx) : "c" (__xcr_no));
return ((unsigned __int64)__edx << 32) | __eax; return ((unsigned __int64)__edx << 32) | __eax;
} }
static __inline__ void __DEFAULT_FN_ATTRS static __inline__ void __DEFAULT_FN_ATTRS
__halt(void) { __halt(void) {
__asm__ volatile ("hlt"); __asm__ volatile ("hlt");
} }
static __inline__ void __DEFAULT_FN_ATTRS
__nop(void) {
__asm__ volatile ("nop");
}
#endif #endif
/*----------------------------------------------------------------------------*\ /*----------------------------------------------------------------------------*\
|* Privileged intrinsics |* Privileged intrinsics
\*----------------------------------------------------------------------------*/ \*----------------------------------------------------------------------------*/
#if defined(__i386__) || defined(__x86_64__) #if defined(__i386__) || defined(__x86_64__)
static __inline__ unsigned __int64 __DEFAULT_FN_ATTRS static __inline__ unsigned __int64 __DEFAULT_FN_ATTRS
__readmsr(unsigned long __register) { __readmsr(unsigned long __register) {
Show All 33 Lines

cfe/trunk/test/Headers/ms-intrin.cpp

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines#ifdef _M_X64
__stosq(0, 0, 0); __stosq(0, 0, 0);
#endif #endif
int info[4]; int info[4];
__cpuid(info, 0); __cpuid(info, 0);
__cpuidex(info, 0, 0); __cpuidex(info, 0, 0);
_xgetbv(0); _xgetbv(0);
__halt(); __halt();
__nop();
__readmsr(0); __readmsr(0);
// FIXME: Call these in 64-bit too once the intrinsics have been fixed to // FIXME: Call these in 64-bit too once the intrinsics have been fixed to
// work there, PR19301 // work there, PR19301
#ifndef _M_X64 #ifndef _M_X64
__readcr3(); __readcr3();
__writecr3(0); __writecr3(0);
#endif #endif
#ifdef _M_ARM #ifdef _M_ARM
__dmb(_ARM_BARRIER_ISHST); __dmb(_ARM_BARRIER_ISHST);
#endif #endif
} }