Page MenuHomePhabricator

Dispatch without hash table lookup.
ClosedPublic

Authored by ruiu on Sep 2 2016, 11:41 AM.

Details

Summary

Cmd used to be the single central place to dispatch. It is not longer
the case because we have a logic for readProvideOrAssignment().
This patch removes the hash table so that evrything is in a single
function. This is slightly verbose but should improve readability.

Diff Detail

Repository
rL LLVM

Event Timeline

ruiu updated this revision to Diff 70199.Sep 2 2016, 11:41 AM
ruiu retitled this revision from to Dispatch without hash table lookup..
ruiu updated this object.
ruiu added a reviewer: grimar.
ruiu added a subscriber: llvm-commits.
grimar accepted this revision.Sep 2 2016, 11:55 AM
grimar edited edge metadata.

Honestly saying I do not like both ways of dispatching. But have no any suggestions here.
I agree that it is probably slightly more readable now when we have readProvideOrAssignment, so LGTM.

This revision is now accepted and ready to land.Sep 2 2016, 11:55 AM
This revision was automatically updated to reflect the committed changes.