This is an archive of the discontinued LLVM Phabricator instance.

Misspelled checker description (argument comment)
ClosedPublic

Authored by szepet on Sep 1 2016, 8:29 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

szepet updated this revision to Diff 70015.Sep 1 2016, 8:29 AM
szepet retitled this revision from to Misspelled checker description (argument comment).
szepet updated this object.
szepet added a project: Restricted Project.
alexfh requested changes to this revision.Sep 7 2016, 4:16 AM
alexfh edited edge metadata.
alexfh added inline comments.
docs/clang-tidy/checks/misc-argument-comment.rst
27 ↗(On Diff #70015)

Good catch!

It would be better to avoid double negation. E.g. When non-zero, the check will take into account leading and trailing underscores..... I'd also add Default is zero., if it's not there. (A full-context diff would make it easier to see what's in the rest of the document).

This revision now requires changes to proceed.Sep 7 2016, 4:16 AM
szepet updated this revision to Diff 71929.Sep 20 2016, 7:14 AM
szepet edited edge metadata.
szepet marked an inline comment as done.

rewritten description

docs/clang-tidy/checks/misc-argument-comment.rst
27 ↗(On Diff #70015)

Sorry for not uploading the whole diff.
I have rewritten it based on the comment but I liked the word 'ignore' so came up with an intermediate solution.

alexfh accepted this revision.Sep 20 2016, 7:37 AM
alexfh edited edge metadata.

LG. Thank you!

This revision is now accepted and ready to land.Sep 20 2016, 7:37 AM

Looks like patch was not committed.

This revision was automatically updated to reflect the committed changes.