This is an archive of the discontinued LLVM Phabricator instance.

Fix the use of unitialized value while reporting double free in ASAN.
ClosedPublic

Authored by krasin on Aug 31 2016, 4:50 PM.

Reviewers

Commits

Summary

This is a follow up to https://reviews.llvm.org/rL280201 where this issue was introduced.

krasin retitled this revision from to Fix the use of unitialized value while reporting double free in ASAN..

krasin updated this object.

krasin added a reviewer: filcab.

This revision was automatically updated to reflect the committed changes.

Path

Size

compiler-rt/

trunk/

lib/

asan/

1 line

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Lines	struct ErrorDoubleFree : ErrorBase {
BufferedStackTrace *second_free_stack;		BufferedStackTrace *second_free_stack;
// VS2013 doesn't implement unrestricted unions, so we need a trivial default		// VS2013 doesn't implement unrestricted unions, so we need a trivial default
// constructor		// constructor
ErrorDoubleFree() = default;		ErrorDoubleFree() = default;
ErrorDoubleFree(uptr addr, u32 tid_, BufferedStackTrace *stack)		ErrorDoubleFree(uptr addr, u32 tid_, BufferedStackTrace *stack)
: tid(tid_), second_free_stack(stack) {		: tid(tid_), second_free_stack(stack) {
CHECK_GT(second_free_stack->size, 0);		CHECK_GT(second_free_stack->size, 0);
GetHeapAddressInformation(addr, 1, &addr_description);		GetHeapAddressInformation(addr, 1, &addr_description);
		scariness.Clear();
scariness.Scare(42, "double-free");		scariness.Scare(42, "double-free");
}		}
void Print();		void Print();
};		};

enum ErrorKind {		enum ErrorKind {
kErrorKindInvalid = 0,		kErrorKindInvalid = 0,
kErrorKindStackOverflow,		kErrorKindStackOverflow,
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines