This is an archive of the discontinued LLVM Phabricator instance.

[SLP] Sink debug after checking for matching types/opcode.
ClosedPublic

Authored by mcrosier on Aug 31 2016, 10:34 AM.

Details

Summary

Trivial refactoring. I was working through a few of the existing lit test cases with debug enabled and I found it to be misleading to print this message and then immediate return because the types/opcode don't match.

Chad

Diff Detail

Event Timeline

mcrosier updated this revision to Diff 69876.Aug 31 2016, 10:34 AM
mcrosier retitled this revision from to [SLP] Sink debug after checking for matching types/opcode..
mcrosier updated this object.
mcrosier added reviewers: mssimpso, mkuper, eeckstein.
mcrosier added a subscriber: llvm-commits.
mssimpso accepted this revision.Aug 31 2016, 10:37 AM
mssimpso edited edge metadata.

LGTM!

This revision is now accepted and ready to land.Aug 31 2016, 10:37 AM
mkuper edited edge metadata.Aug 31 2016, 10:39 AM

Maybe leave it where it is, but change the text from "Vectorizing" to "Trying to vectorize"?
With this patch it seems like it's neither here nor there - passing the "sameness" check still no guarantee we'll actually vectorize.

(Or even better, leave it where it is, change the text to "Trying to vectorize", and add another debug print once we pass the type/opcode check?)

This revision was automatically updated to reflect the committed changes.

(I don't feel strongly about this, if both of you feel this is better, SGTM.)

(Or even better, leave it where it is, change the text to "Trying to vectorize", and add another debug print once we pass the type/opcode check?)

I committed this change, but I'll make your suggestion happen, Michael. Thanks.

(Or even better, leave it where it is, change the text to "Trying to vectorize", and add another debug print once we pass the type/opcode check?)

I committed this change, but I'll make your suggestion happen, Michael. Thanks.

And now I'm leaning toward just changing the original statement to say "Trying to vectorize a list.."