Page MenuHomePhabricator

consistently add \n to log and trace messages
ClosedPublic

Authored by emaste on Aug 30 2016, 6:44 AM.

Details

Summary

Previously most messages included a newline, but a few of them were missing. Fix these and simplify by just adding the newline in the _LIBUNWIND_LOG macro itself.

Example output from unpatched libunwind, from https://lists.freebsd.org/pipermail/freebsd-ports/2016-August/104595.html:

libuwind: _unw_add_dynamic_fde: bad fde: FDE is really a CIElibuwind:
_unw_add_dynamic_fde: bad fde: FDE is really a CIElibuwind:
_unw_add_dynamic_fde: bad fde: FDE is really a CIElibuwind:

Diff Detail

Repository
rL LLVM

Event Timeline

emaste updated this revision to Diff 69672.Aug 30 2016, 6:44 AM
emaste retitled this revision from to consistently add \n to log and trace messages.
emaste updated this object.
emaste added reviewers: compnerd, kledzik.
emaste added a subscriber: llvm-commits.
compnerd accepted this revision.Aug 30 2016, 8:03 AM
compnerd edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Aug 30 2016, 8:03 AM
This revision was automatically updated to reflect the committed changes.