This is an archive of the discontinued LLVM Phabricator instance.

Fix broken macOS LLDB build from r279314
ClosedPublic

Authored by tfiala on Aug 20 2016, 12:08 PM.

Details

Summary

This change replaces angle brackets with quotes for a non-system header that is being included like a system one. The existing behavior breaks the LLDB Xcode build.

I think build break fixes are eligible for post-commit review, but since I hardly touch LLVM, I'm preferring to be safe rather than sorry.

(Also adding Adrian Prantl in case he gets to it sooner.)

Diff Detail

Event Timeline

tfiala updated this revision to Diff 68787.Aug 20 2016, 12:08 PM
tfiala retitled this revision from to Fix broken macOS LLDB build from r279314.
tfiala updated this object.
tfiala added a reviewer: dexonsmith.
tfiala added subscribers: lldb-commits, llvm-commits.
tfiala updated this object.Aug 20 2016, 12:11 PM
tfiala added a reviewer: aprantl.

Committed after email with Duncan:
r279390

tfiala accepted this revision.Sep 12 2016, 11:19 AM
tfiala added a reviewer: tfiala.

Accepting so this can be closed.

This revision is now accepted and ready to land.Sep 12 2016, 11:19 AM
tfiala closed this revision.Sep 12 2016, 11:20 AM

Closing - this was submitted a few weeks ago.