This is an archive of the discontinued LLVM Phabricator instance.

Omit column info for CodeView by default
ClosedPublic

Authored by amccarth on Aug 19 2016, 10:52 AM.

Details

Summary

Clang tracks only start columns, not start-end ranges. CodeView allows for that, but the VS debugger doesn't handle anything less than a complete range well--it either highlights the wrong part of a statement or truncates source lines in the assembly view. It's better to have no column information at all.

So by default, we'll omit the column information for CodeView targeting Windows.

Since the column info is still useful for sanitizers, I've promoted -gcolumn-info (and -gno-column-info) to a CoreOption and added a couple tests to make sure that works for clang-cl.

Diff Detail

Repository
rL LLVM

Event Timeline

amccarth updated this revision to Diff 68713.Aug 19 2016, 10:52 AM
amccarth retitled this revision from to Omit column info for CodeView by default.
amccarth updated this object.
amccarth added a subscriber: cfe-commits.
rnk accepted this revision.Aug 25 2016, 10:26 AM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Aug 25 2016, 10:26 AM
This revision was automatically updated to reflect the committed changes.