This is an archive of the discontinued LLVM Phabricator instance.

[LLVM] [cmake] Ensure proper -I along with -include on SunOS, #29013
Needs ReviewPublic

Authored by mgorny on Aug 17 2016, 6:25 AM.

Details

Reviewers
EricWF
Summary

As described on the bug, the '-include' flag added to C++ flags on SunOS gets propagated to subprojects such as libc++ while they do not have matching include directories enabled. This simple patch adds an -I flag along with the -include to ensure that the compiler is able to find the requested include.

Bug: https://llvm.org/bugs/show_bug.cgi?id=29013

Diff Detail

Event Timeline

mgorny updated this revision to Diff 68341.Aug 17 2016, 6:25 AM
mgorny retitled this revision from to [LLVM] [cmake] Ensure proper -I along with -include on SunOS, #29013.
mgorny updated this object.
mgorny added a reviewer: EricWF.
mgorny added a subscriber: llvm-commits.
EricWF edited edge metadata.Dec 5 2016, 1:18 AM

@mgorny: I would suggest adding some reviews that frequently review LLVM CMake changes since this change will affect more than just libc++.