Page MenuHomePhabricator

[VFS] Add 'ignore-non-existent-contents' field to YAML
ClosedPublic

Authored by bruno on Aug 11 2016, 1:22 PM.

Details

Summary

Add 'ignore-non-existent-contents' to tell the VFS whether an invalid path
obtained via 'external-contents' should cause iteration on the VFS to stop.

If 'true', the VFS should ignore the entry and continue with the next. Allows
YAML files to be shared across multiple compiler invocations regardless of
prior existent paths in 'external-contents'. This global value is overridable
on a per-file basis.

This only adds the parsing part. Logic to actually use it will come next.

Diff Detail

Event Timeline

bruno updated this revision to Diff 67736.Aug 11 2016, 1:22 PM
bruno retitled this revision from to [VFS] Add 'ignore-non-existent-contents' field to YAML.
bruno updated this object.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
benlangmuir edited edge metadata.Aug 11 2016, 2:48 PM

This should have a test for the writer change. Otherwise LGTM.

bruno accepted this revision.Aug 11 2016, 7:02 PM
bruno added a reviewer: bruno.

Applied your comments, and committed in r278456!

Thanks

This revision is now accepted and ready to land.Aug 11 2016, 7:02 PM
bruno closed this revision.Aug 11 2016, 7:12 PM