This is an archive of the discontinued LLVM Phabricator instance.

Fix building builtins via plain "make"
AbandonedPublic

Authored by mstorsjo on Aug 10 2016, 5:07 AM.

Details

Reviewers
beanz
Summary

When the autoconf support was removed in SVN rev 258863, the
references to profiling were removed from clang_darwin.mk, but
not from clang_linux.mk.

This fixes e.g. "make clang_linux-builtins-x86_64", which previously
errored out with this:
Makefile:267: *** SelectFunctionDir: invalid function name "GCDAProfiling" (no such function). Stop.

Diff Detail

Event Timeline

mstorsjo updated this revision to Diff 67508.Aug 10 2016, 5:07 AM
mstorsjo retitled this revision from to Fix building builtins via plain "make".
mstorsjo updated this object.
mstorsjo added a reviewer: beanz.
mstorsjo added a subscriber: llvm-commits.
beanz edited edge metadata.Aug 22 2016, 9:27 AM

@mstorsjo, I don't believe we should accept this patch because building compiler-rt without CMake is not supported. These files escaped my initial purge of makefiles because there were specific use cases that CMake couldn't handle. Since then we've made extensions to our CMake system to cover the missing use cases, so these files should all be removed. I've sent out a patch for review which does exactly that (D23777).

If there is a reason you're still using make instead of CMake when building the builtins, you should speak up now, because I think all use cases are covered.

mstorsjo abandoned this revision.Aug 22 2016, 1:42 PM

Ok, fair enough - abandoning. The only reason I tried this instead of cmake was because I started off of someone's build script that used this way of building, and it didn't seem to be purged yet, only slightly broken.