This is an archive of the discontinued LLVM Phabricator instance.

Fixed x2APIC discovery for 256-processor architectures
ClosedPublic

Authored by AndreyChurbanov on Aug 5 2016, 6:45 AM.

Details

Summary

CPUID returns values in bits 0-15 of ebx those were mistakenly masked by 0xFF reading only bits 0-7. Thus on 256-processor architecture we got value 0 that is wrong. Masking by 0xFFFF fixes the problem.

Diff Detail

Repository
rL LLVM

Event Timeline

AndreyChurbanov retitled this revision from to Fixed x2APIC discovery for 256-processor architectures.
AndreyChurbanov updated this object.
AndreyChurbanov added reviewers: tlwilmar, jlpeyton.
AndreyChurbanov set the repository for this revision to rL LLVM.
AndreyChurbanov added a subscriber: openmp-commits.
tlwilmar accepted this revision.Aug 5 2016, 8:58 AM
tlwilmar edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 5 2016, 8:58 AM
This revision was automatically updated to reflect the committed changes.