This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Ignore various test artifacts (NFCI)
ClosedPublic

Authored by vsk on Jul 29 2016, 5:17 PM.

Diff Detail

Event Timeline

vsk updated this revision to Diff 66206.Jul 29 2016, 5:17 PM
vsk retitled this revision from to [lldb] Ignore various test artifacts (NFCI).
vsk updated this object.
vsk added a reviewer: tfiala.
vsk added a subscriber: llvm-commits.
tfiala requested changes to this revision.Jul 29 2016, 5:34 PM
tfiala edited edge metadata.
tfiala added inline comments.
.gitignore
38

Fine

39

Fine.

40

We don't want this one. Even though some tests are being bad (eh, hem, test writers) and leaving their junk around (typically the auto-generated tests like inlines), we do have plenty of Makefile files in the test subdirectory that are part of the repo and are modified. Putting this here will create some level of chaos when changes are made to those Makefiles locally and are masked out by this .gitignore.

If you don't plan on changing Makefile content yourself, you could go ahead and put this line in your user's global gitignore file if you set one up.

This revision now requires changes to proceed.Jul 29 2016, 5:34 PM
tfiala edited edge metadata.Jul 29 2016, 5:35 PM
tfiala added a subscriber: lldb-commits.
vsk updated this revision to Diff 66209.Jul 29 2016, 6:41 PM
vsk edited edge metadata.
  • Don't ignore Makefiles per Todd's suggestion.
tfiala accepted this revision.Jul 29 2016, 9:14 PM
tfiala edited edge metadata.

Looks good!

We're working on cleaning up the makefiles. Thanks for pointing that out.

This revision is now accepted and ready to land.Jul 29 2016, 9:14 PM
This revision was automatically updated to reflect the committed changes.