Fix -break-insert not working when using absolute paths

[malaperle]

Summary

When trying to parse the -break-insert arguments as a named location, the string parsing was not configured to allow directory paths. This patch adds a constructor to allow the parsing of string as directory path along with the other parameters.

This fixes https://llvm.org/bugs/show_bug.cgi?id=28709

[ki.stfu]

Could you add a test case for this in packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py?

[clayborg]

Add a test and this is good to go.

[malaperle]

The test actually already existed but now it passed.

[malaperle]

BTW, I had trouble running the lldb-mi tests. There seems to be a bug in dotest.py.

lldbMiExec = lldbtest_config.lldbExec + "-mi"

I used 'python dotest.py --executable /path/to/llvm/build/bin/lldb

This failed for me because lldb is a symlink to lldb-4.0.0 and lldb-4.0.0-mi doesn't exist. I'm not sure if there either a way to not make it resolve the symlink or if the script should be changed.

[malaperle]

In D22902#500174, @malaperle wrote:

This failed for me because lldb is a symlink to lldb-4.0.0 and lldb-4.0.0-mi doesn't exist. I'm not sure if there either a way to not make it resolve the symlink or if the script should be changed.

By fail, I mean that the tests were getting skipped.

[clayborg]

There should be a way to specify the lldb-mi binary. If there isn't feel free to add one to the test suite.

[malaperle]

Thanks! Newcomer silly question: now that the change is accepted, is there any action required on my end?

[ki.stfu]

No. I'm going to land it right now! Thanks!

[malaperle]

Would it be possible to apply this fix to the release_39 branch?

lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py

def test_lldbmi_break_insert_file_line(self):
 
         # Test that non-pending BP was set correctly
         self.runCmd("-exec-continue")
         self.expect("\^running")
         self.expect("\*stopped,reason=\"breakpoint-hit\"")
 
     @skipIfWindows #llvm.org/pr24452: Get lldb-mi tests working on Windows
     @skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread races
-    @unittest2.expectedFailure("-break-insert doesn't work for absolute path")
     def test_lldbmi_break_insert_file_line_absolute_path(self):
         """Test that 'lldb-mi --interpreter' works for file:line breakpoints."""
 
         self.spawnLldbMi(args = None)
 
         self.runCmd("-file-exec-and-symbols %s" % self.myexe)
         self.expect("\^done")
 

lldb/trunk/tools/lldb-mi/MICmdArgValString.h

 {
     // Methods:
   public:
     /* ctor */ CMICmdArgValString();
     /* ctor */ CMICmdArgValString(const bool vbAnything);
     /* ctor */ CMICmdArgValString(const bool vbHandleQuotes, const bool vbAcceptNumbers, const bool vbHandleDirPaths);
     /* ctor */ CMICmdArgValString(const CMIUtilString &vrArgName, const bool vbMandatory, const bool vbHandleByCmd,
                                   const bool vbHandleQuotes = false, const bool vbAcceptNumbers = false);
+    /* ctor */ CMICmdArgValString(const CMIUtilString &vrArgName, const bool vbMandatory, const bool vbHandleByCmd,
+                                  const bool vbHandleQuotes, const bool vbAcceptNumbers, const bool vbHandleDirPaths);
     //
     bool IsStringArg(const CMIUtilString &vrTxt) const;
 
     // Overridden:
   public:
     // From CMICmdArgValBase
     /* dtor */ ~CMICmdArgValString() override;
     // From CMICmdArgSet::IArg

lldb/trunk/tools/lldb-mi/MICmdArgValString.cpp

CMICmdArgValString::CMICmdArgValString(const CMIUtilString &vrArgName, const bool vbMandatory, const bool vbHandleByCmd,
     , m_bHandleQuotedString(vbHandleQuotes)
     , m_bAcceptNumbers(vbAcceptNumbers)
     , m_bHandleDirPaths(false)
     , m_bHandleAnything(false)
 {
 }
 
 //++ ------------------------------------------------------------------------------------
+// Details: CMICmdArgValString constructor.
+// Type:    Method.
+// Args:    vrArgName       - (R) Argument's name to search by.
+//          vbMandatory     - (R) True = Yes must be present, false = optional argument.
+//          vbHandleByCmd   - (R) True = Command processes *this option, false = not handled.
+//          vbHandleQuotes  - (R) True = Parse a string surrounded by quotes spaces are not delimiters, false = only text up to
+// next delimiting space character.
+//          vbAcceptNumbers - (R) True = Parse a string and accept as a number if number, false = numbers not recognised as
+//          vbHandleDirPaths - (R) True = Parse a string and accept as a file path if a path, false = file paths are not
+// string types.
+// Return:  None.
+// Throws:  None.
+//--
+CMICmdArgValString::CMICmdArgValString(const CMIUtilString &vrArgName, const bool vbMandatory, const bool vbHandleByCmd,
+    const bool vbHandleQuotes, const bool vbAcceptNumbers, const bool vbHandleDirPaths)
+    : CMICmdArgValBaseTemplate(vrArgName, vbMandatory, vbHandleByCmd)
+    , m_bHandleQuotedString(vbHandleQuotes)
+    , m_bAcceptNumbers(vbAcceptNumbers)
+    , m_bHandleDirPaths(vbHandleDirPaths)
+    , m_bHandleAnything(false)
+{
+}
+
+//++ ------------------------------------------------------------------------------------
 // Details: CMICmdArgValString destructor.
 // Type:    Overridden.
 // Args:    None.
 // Return:  None.
 // Throws:  None.
 //--
 CMICmdArgValString::~CMICmdArgValString()
 {

lldb/trunk/tools/lldb-mi/MICmdCmdBreak.cpp

CMICmdCmdBreakInsert::ParseArgs()
     m_setCmdArgs.Add(new CMICmdArgValOptionShort(m_constStrArgNamedDisableBrkPt, false, false));
     // Not implemented m_setCmdArgs.Add(new CMICmdArgValOptionShort( m_constStrArgNamedTracePt, false, false));
     m_setCmdArgs.Add(new CMICmdArgValOptionShort(m_constStrArgNamedConditionalBrkPt, false, true,
                                                    CMICmdArgValListBase::eArgValType_StringQuoted, 1));
     m_setCmdArgs.Add(
         new CMICmdArgValOptionShort(m_constStrArgNamedInoreCnt, false, true, CMICmdArgValListBase::eArgValType_Number, 1));
     m_setCmdArgs.Add(new CMICmdArgValOptionShort(m_constStrArgNamedRestrictBrkPtToThreadId, false, true,
                                                    CMICmdArgValListBase::eArgValType_Number, 1));
-    m_setCmdArgs.Add(new CMICmdArgValString(m_constStrArgNamedLocation, false, true));
+    m_setCmdArgs.Add(new CMICmdArgValString(m_constStrArgNamedLocation, false, true, false, false, true));
     return ParseValidateCmdOptions();
 }
 
 //++ ------------------------------------------------------------------------------------
 // Helper function for CMICmdCmdBreakInsert::Execute().
 //
 // Given a string, return the position of the ':' separator in 'file:func'
 // or 'file:line', if any.  If not found, return npos.  For example, return