Details
Diff Detail
Event Timeline
clang-query/QueryParser.cpp | ||
---|---|---|
51 ↗ | (On Diff #5755) | When reading this without the context of how it's used it's hard to know why this is templated, and what the template parameters are supposed to be. |
64–71 ↗ | (On Diff #5755) | I find this somewhat hard to read.
|
clang-query/QueryParser.h | ||
23 ↗ | (On Diff #5755) | While mostly self-explanatory, I still think the public interface might benefit from some comments... |
53 ↗ | (On Diff #5755) | I think some of the code later might be simpler if this was an offset from Begin. I might be missing something, though. |
- Address review comments
clang-query/QueryParser.cpp | ||
---|---|---|
51 ↗ | (On Diff #5755) | Added some comments (here and for lexOrCompleteWord). |
64–71 ↗ | (On Diff #5755) |
Done.
Done.
No particularly good reason. In fact I think the call to memcmp was a memory error. I've changed this as you suggested. I also got rid of the SeenCases set; I replaced it with a new IsCompletion argument to Case which should make that logic more readable. |
clang-query/QueryParser.h | ||
23 ↗ | (On Diff #5755) | Added. |
53 ↗ | (On Diff #5755) | The main reason I decided to make this a pointer was that Begin moves along the string as we parse, and if this were an offset we would need to keep it updated. |