This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] Supress warnings of missing reference output files using a default reference.
ClosedPublic

Authored by asbirlea on Jul 19 2016, 4:08 PM.

Details

Summary

For the Bitcode tests, there is a large number of tests that do not have or need a reference file, leading to a warning for each test.
Yet, it's still cleaner to use the same methods in SingleMulti.cmake which trigger the warning.
Attempting to bypass this by adding a default reference which can apply to a large number of tests.
Alternative suggestions on addressing this are welcome.

Diff Detail

Repository
rL LLVM

Event Timeline

asbirlea updated this revision to Diff 64592.Jul 19 2016, 4:08 PM
asbirlea retitled this revision from to [test-suite] Supress warnings of missing reference output files using a default reference..
asbirlea updated this object.
mehdi_amini edited edge metadata.Jul 19 2016, 4:18 PM

There is a bunch of if(NOT DEFINED ... in this CMake file, can this be used to add a new variable and test with If(NOT DEFINED NO_REFERENCE_OUTPUT) (or similar)?

I like that idea a lot more, I'll update the patch.

asbirlea updated this revision to Diff 64611.Jul 19 2016, 4:58 PM
asbirlea edited edge metadata.

Update patch to set (and check) a variable, for tests with no reference required.

mehdi_amini accepted this revision.Jul 19 2016, 5:10 PM
mehdi_amini edited edge metadata.

Unless @MatzeB objects, that looks fine to me.

This revision is now accepted and ready to land.Jul 19 2016, 5:10 PM

Thanks, I'll wait until tomorrow, in case there are objections.

This revision was automatically updated to reflect the committed changes.