Page Menu
Home
Phabricator
This is an archive of the discontinued LLVM Phabricator instance.
Paths
Table of Contents
t
-
llvm/trunk/lib/Support/
-
trunk/
-
lib/
-
Support/
-
CommandLine.cpp
Hide Panel
f
Keyboard Reference
?
Differential
D22540
Get rid of call to StringRef::substr that's never used.
Closed
Public
Authored by
jlebar
on Jul 19 2016, 3:11 PM.
Download Raw Diff
Details
Reviewers
majnemer
Commits
rGea9598b1f4d7: Get rid of call to StringRef::substr that's never used.
rL276057: Get rid of call to StringRef::substr that's never used.
Summary
substr doesn't modify the string, so this line has no effect.
Diff Detail
Repository
rL LLVM
Event Timeline
jlebar
updated this revision to
Diff 64573
.
Jul 19 2016, 3:11 PM
jlebar
retitled this revision from
to
Get rid of call to StringRef::substr that's never used.
.
jlebar
updated this object.
jlebar
added a reviewer:
majnemer
.
jlebar
mentioned this in
D22541: [ADT] Warn on unused results from ArrayRef and StringRef functions that read like they might mutate.
.
jlebar
added a subscriber:
llvm-commits
.
majnemer
accepted this revision.
Jul 19 2016, 3:30 PM
majnemer
edited edge metadata.
Comment Actions
LGTM
This revision is now accepted and ready to land.
Jul 19 2016, 3:30 PM
Closed by commit
rL276057: Get rid of call to StringRef::substr that's never used.
(authored by
jlebar
).
·
Explain Why
Jul 19 2016, 4:26 PM
This revision was automatically updated to reflect the committed changes.
jlebar
mentioned this in
rL276058: [ADT] Warn on unused results from ArrayRef and StringRef functions that read…
.