Page MenuHomePhabricator

Make ThreadPlanStepInstruction's constructor public.
ClosedPublic

Authored by sas on Jul 11 2016, 11:00 AM.

Details

Summary

Some thread plans have public contructors, some others have protected
constructors with friend classes. Not sure how these were determined,
but this thread plan is going to be required to implement trampoline
step-through on Windows.

Diff Detail

Repository
rL LLVM

Event Timeline

sas updated this revision to Diff 63540.Jul 11 2016, 11:00 AM
sas retitled this revision from to Make ThreadPlanStepInstruction's constructor public..
sas updated this object.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
clayborg resigned from this revision.Jul 11 2016, 11:07 AM
clayborg edited reviewers, added: jingham; removed: clayborg.

Looks good to me, but for any thread plan stuff, I will defer to Jim Ingham.

jingham accepted this revision.Jul 11 2016, 2:37 PM
jingham edited edge metadata.

Sure, yes.

This revision is now accepted and ready to land.Jul 11 2016, 2:37 PM
sas updated this revision to Diff 63625.Jul 11 2016, 6:49 PM
sas edited edge metadata.

Rebase.

This revision was automatically updated to reflect the committed changes.