This is an archive of the discontinued LLVM Phabricator instance.

Differential D22200

[libc++] Fix macOS Sierra build issues by declaring basic_string(const allocator_type& __a) noexcept.
Needs ReviewPublic

Authored by EtherTyper on Jul 10 2016, 9:51 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Repository
rL LLVM

Event Timeline

EtherTyper updated this revision to Diff 63429.Jul 10 2016, 9:51 AM
EtherTyper retitled this revision from to [libc++] Fix macOS Sierra build issues by declaring basic_string(const allocator_type& __a) noexcept..
EtherTyper updated this object.
EtherTyper set the repository for this revision to rL LLVM.
EtherTyper changed the edit policy from "All Users" to "Administrators".
EtherTyper added a subscriber: cfe-commits.
bruno added a subscriber: bruno.Jul 18 2016, 10:58 AM

Hi,

Can you provide more details on what the build issues are? It seems that the line you introduce is covered in the ifdef below, wonder why it's not triggering in your build?

Revision Contents

PathSize
include/
2 lines

Diff 63429

include/string

Show First 20 Lines • Show All 1,987 Lines • ▼ Show 20 Lines
#if _LIBCPP_DEBUG_LEVEL >= 2 #if _LIBCPP_DEBUG_LEVEL >= 2
__get_db()->__insert_c(this); __get_db()->__insert_c(this);
#endif #endif
__zero(); __zero();
} }
template <class _CharT, class _Traits, class _Allocator> template <class _CharT, class _Traits, class _Allocator>
inline _LIBCPP_INLINE_VISIBILITY inline _LIBCPP_INLINE_VISIBILITY
basic_string<_CharT, _Traits, _Allocator>::basic_string(const allocator_type& __a) basic_string<_CharT, _Traits, _Allocator>::basic_string(const allocator_type& __a) noexcept(is_nothrow_copy_constructible<allocator_type>::value)
#if _LIBCPP_STD_VER <= 14 #if _LIBCPP_STD_VER <= 14
_NOEXCEPT_(is_nothrow_copy_constructible<allocator_type>::value) _NOEXCEPT_(is_nothrow_copy_constructible<allocator_type>::value)
#else #else
_NOEXCEPT _NOEXCEPT
#endif #endif
: __r_(__a) : __r_(__a)
{ {
#if _LIBCPP_DEBUG_LEVEL >= 2 #if _LIBCPP_DEBUG_LEVEL >= 2
▲ Show 20 Lines • Show All 2,312 Lines • Show Last 20 Lines