Page MenuHomePhabricator

MSP430: Avoid implicit iterator conversions, NFC
ClosedPublic

Authored by dexonsmith on Jul 8 2016, 12:16 PM.

Details

Reviewers
asl
Summary

Avoid implicit conversions from MachineInstrBundleInstr to MachineInstr*
in the MSP430 backend by preferring MachineInstr& over MachineInstr*
when a pointer isn't nullable.

Diff Detail

Event Timeline

dexonsmith updated this revision to Diff 63281.Jul 8 2016, 12:16 PM
dexonsmith updated this revision to Diff 63283.
dexonsmith retitled this revision from to MSP430: Avoid implicit iterator conversions, NFC.
dexonsmith updated this object.
dexonsmith added a subscriber: llvm-commits.

FYI: these diffs are identical; the re-upload just has extra context to make Phab users happy.

asl accepted this revision.Jul 8 2016, 1:42 PM
asl added a reviewer: asl.
asl added a subscriber: asl.

LGTM from me as well.

This revision is now accepted and ready to land.Jul 8 2016, 1:42 PM

Thanks both for the review. Committed in r274933.

dexonsmith closed this revision.Jul 8 2016, 2:27 PM