This is an archive of the discontinued LLVM Phabricator instance.

[SystemZ] Implement shouldExtI32* hooks.
AbandonedPublic

Authored by • koriakin on Jun 28 2016, 11:06 AM.

Download Raw Diff

Details

Reviewers

Summary

On SystemZ, i32 parameters corresponding to C-level int or unsigned int
need signext or zeroext attribute, respectively. Fill the TTI hooks so
that LLVM passes inserting library calls with such parameters know to use
the attribute.

This makes compiler-rt profile testsuite pass on s390x.

Diff Detail

Repository: rL LLVM

Event Timeline

• koriakin updated this revision to Diff 62114.Jun 28 2016, 11:06 AM

• koriakin retitled this revision from to [SystemZ] Implement shouldExtI32* hooks..

• koriakin updated this object.

• koriakin added a reviewer: uweigand.

• koriakin set the repository for this revision to rL LLVM.

• koriakin added a subscriber: llvm-commits.

Depends on D21736, D21739.

LGTM once the base patch is in.

This revision is now accepted and ready to land.Jun 28 2016, 12:31 PM

• koriakin added a child revision: D21738: [profile] Enable on SystemZ..Jun 29 2016, 12:45 AM

Abandoning in favor of D21739.

Revision Contents

Path

Size

lib/

Target/

SystemZ/

SystemZTargetTransformInfo.h

3 lines

test/

Instrumentation/

InstrProfiling/

icall.ll

6 lines

Diff 62114

lib/Target/SystemZ/SystemZTargetTransformInfo.h

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines	public:

/// \name Vector TTI Implementations		/// \name Vector TTI Implementations
/// @{		/// @{

unsigned getNumberOfRegisters(bool Vector);		unsigned getNumberOfRegisters(bool Vector);
unsigned getRegisterBitWidth(bool Vector);		unsigned getRegisterBitWidth(bool Vector);

/// @}		/// @}

		bool shouldExtI32Param() const { return true; }
		bool shouldExtI32Result() const { return true; }
};		};

} // end namespace llvm		} // end namespace llvm

#endif		#endif

test/Instrumentation/InstrProfiling/icall.ll

	;; Check that static counters are allocated for value profiler			;; Check that static counters are allocated for value profiler

	; RUN: opt < %s -mtriple=x86_64-apple-macosx10.10.0 -vp-static-alloc=true -instrprof -S \| FileCheck %s --check-prefix=STATIC			; RUN: opt < %s -mtriple=x86_64-apple-macosx10.10.0 -vp-static-alloc=true -instrprof -S \| FileCheck %s --check-prefix=STATIC
	; RUN: opt < %s -mtriple=x86_64-unknown-linux -instrprof -vp-static-alloc=true -S \| FileCheck %s --check-prefix=STATIC			; RUN: opt < %s -mtriple=x86_64-unknown-linux -instrprof -vp-static-alloc=true -S \| FileCheck %s --check-prefix=STATIC
				; RUN: opt < %s -mtriple=s390x-unknown-linux -instrprof -vp-static-alloc=true -S \| FileCheck %s --check-prefix=STATIC-EXT
	; RUN: opt < %s -mtriple=x86_64-apple-macosx10.10.0 -vp-static-alloc=false -instrprof -S \| FileCheck %s --check-prefix=DYN			; RUN: opt < %s -mtriple=x86_64-apple-macosx10.10.0 -vp-static-alloc=false -instrprof -S \| FileCheck %s --check-prefix=DYN
	; RUN: opt < %s -mtriple=x86_64-unknown-linux -instrprof -vp-static-alloc=false -S \| FileCheck %s --check-prefix=DYN			; RUN: opt < %s -mtriple=x86_64-unknown-linux -instrprof -vp-static-alloc=false -S \| FileCheck %s --check-prefix=DYN


	@__profn_foo = private constant [3 x i8] c"foo"			@__profn_foo = private constant [3 x i8] c"foo"

	define i32 @foo(i32 ()* ) {			define i32 @foo(i32 ()* ) {
	call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12884901887, i32 1, i32 0)			call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12884901887, i32 1, i32 0)
	Show All 11 Lines

	attributes #0 = { nounwind }			attributes #0 = { nounwind }

	; STATIC: @__profvp_foo			; STATIC: @__profvp_foo
	; STATIC: @__llvm_prf_vnodes			; STATIC: @__llvm_prf_vnodes

	; DYN-NOT: @__profvp_foo			; DYN-NOT: @__profvp_foo
	; DYN-NOT: @__llvm_prf_vnodes			; DYN-NOT: @__llvm_prf_vnodes
				; STATIC: call void @__llvm_profile_instrument_target(i64 %3, i8* bitcast ({ i64, i64, i64, i8, i8, i32, [1 x i16] } @__profd_foo to i8*), i32 0)
				; STATIC-EXT: call void @__llvm_profile_instrument_target(i64 %3, i8* bitcast ({ i64, i64, i64, i8, i8, i32, [1 x i16] } @__profd_foo to i8*), i32 zeroext 0)

				; STATIC: declare void @__llvm_profile_instrument_target(i64, i8*, i32)
				; STATIC-EXT: declare void @__llvm_profile_instrument_target(i64, i8*, i32 zeroext)