Page MenuHomePhabricator

[codeview] Emit retained types
ClosedPublic

Authored by hans on Jun 22 2016, 5:45 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

hans updated this revision to Diff 61629.Jun 22 2016, 5:45 PM
hans retitled this revision from to [codeview] Emit retained types.
hans updated this object.
hans added a reviewer: rnk.
hans added a subscriber: llvm-commits.
rnk added inline comments.Jun 23 2016, 8:25 AM
test/DebugInfo/COFF/retained-types.ll
14 ↗(On Diff #61629)

Can you cut the checks down to look for the two Struct records and wild card away all the type indices? All the other types are not relevant to the test. Something like:

; CHECK: Struct ({{.*}}) {
; CHECK-NEXT: ...

; CHECK: Struct ({{.*}}) {
; CHECK-NEXT: ...

I was thinking about changing our dumper output to print the name of the type on the first line of the record so that it plays better with FileCheck, something like:

Struct A (0xNNNN) {
... }
Pointer A* (0xNNNN) {
... }
rnk accepted this revision.Jun 23 2016, 8:30 AM
rnk edited edge metadata.

lgtm with that change, forgot to stamp

This revision is now accepted and ready to land.Jun 23 2016, 8:30 AM
This revision was automatically updated to reflect the committed changes.