This is an archive of the discontinued LLVM Phabricator instance.

[IRObjectFile] Propagate .weak attribute correctly in symbols
ClosedPublic

Authored by davide on Jun 22 2016, 12:47 PM.

Diff Detail

Event Timeline

davide updated this revision to Diff 61590.Jun 22 2016, 12:47 PM
davide retitled this revision from to [IRObjectFile] Propagate .weak attribute correctly in symbols.
davide updated this object.
davide added a reviewer: rafael.
davide added a subscriber: llvm-commits.
rafael edited edge metadata.Jun 22 2016, 1:40 PM
rafael added a subscriber: rafael.

Lgtm.

We should also add support for weak undefined, but that can be a followup
patch.

Cheers,
Rafael

Lgtm.

We should also add support for weak undefined, but that can be a followup
patch.

Sure thing. Thanks for your review, Rafael.

This revision was automatically updated to reflect the committed changes.