This is an archive of the discontinued LLVM Phabricator instance.

Handle .weak in IRObjectFile RecordStreamer
ClosedPublic

Authored by davide on Jun 17 2016, 10:16 AM.

Diff Detail

Event Timeline

davide updated this revision to Diff 61107.Jun 17 2016, 10:16 AM
davide retitled this revision from to Handle .weak in IRObjectFile RecordStreamer.
davide updated this object.
davide added a reviewer: rafael.
davide added a subscriber: llvm-commits.
rafael edited edge metadata.Jun 17 2016, 10:18 AM
rafael added a subscriber: rafael.

LGTM with a nit:

+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-freebsd11.0"
+
+module asm ".weak libc_blah"
+module asm ".equ
libc_blah, blah"

The test body can be just

module asm ".weak libc_blah"
module asm "
libc_blah:"

no need to include an IR function.

Cheers,
Rafael

This revision was automatically updated to reflect the committed changes.