This is an archive of the discontinued LLVM Phabricator instance.

Differential D21476

Handle .weak in IRObjectFile RecordStreamer
ClosedPublic

Authored by davide on Jun 17 2016, 10:16 AM.

Details

Reviewers
• rafael
Commits
rG16bfa13a7742: [IRObjectFile] Handle .weak in RecordStreamer.
rL273027: [IRObjectFile] Handle .weak in RecordStreamer.

Diff Detail

Event Timeline

davide updated this revision to Diff 61107.Jun 17 2016, 10:16 AM
davide retitled this revision from to Handle .weak in IRObjectFile RecordStreamer.
davide updated this object.
davide added a reviewer: • rafael.
davide added a subscriber: llvm-commits.
• rafael edited edge metadata.Jun 17 2016, 10:18 AM
• rafael added a subscriber: • rafael.

LGTM with a nit:

+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-freebsd11.0"
+
+module asm ".weak libc_blah"
+module asm ".equ libc_blah, blah"

The test body can be just

module asm ".weak libc_blah"
module asm "libc_blah:"

no need to include an IR function.

Cheers,
Rafael

Closed by commit rL273027: [IRObjectFile] Handle .weak in RecordStreamer. (authored by davide). · Explain WhyJun 17 2016, 11:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Object/
2 lines
test/
Object/
X86/
15 lines

Diff 61107

lib/Object/RecordStreamer.cpp

Context not available.
bool RecordStreamer::EmitSymbolAttribute(MCSymbol *Symbol, bool RecordStreamer::EmitSymbolAttribute(MCSymbol *Symbol,
MCSymbolAttr Attribute) { MCSymbolAttr Attribute) {
if (Attribute == MCSA_Global) if (Attribute == MCSA_Global || Attribute == MCSA_Weak)
markGlobal(*Symbol); markGlobal(*Symbol);
return true; return true;
} }
Context not available.

test/Object/X86/nm-bitcodeweak.test

  • This file was added.
; RUN: llvm-as %s -o=%t1
; RUN: llvm-nm %t1 | FileCheck %s
; CHECK: T __libc_blah
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-freebsd11.0"
module asm ".weak __libc_blah"
module asm ".equ __libc_blah, blah"
; Function Attrs: nounwind uwtable
define void @blah() {
ret void
}