This is an archive of the discontinued LLVM Phabricator instance.

Split LLVM_IR module in pieces that use intrinsics.gen and the pieces that don't.
ClosedPublic

Authored by v.g.vassilev on Jun 11 2016, 11:38 AM.

Details

Reviewers
rsmith

Diff Detail

Event Timeline

v.g.vassilev retitled this revision from to Split LLVM_IR module in pieces that use intrinsics.gen and the pieces that don't..
v.g.vassilev updated this object.
v.g.vassilev added a reviewer: rsmith.
v.g.vassilev set the repository for this revision to rL LLVM.
rsmith added inline comments.Jun 14 2016, 4:51 PM
include/llvm/module.modulemap
123

You need this to be a separate top-level module, or it won't help, because each top-level module is built as a single entity (we need the intrinsics_gen output files to be generated before anything in the corresponding top-level module is used).

v.g.vassilev added inline comments.Jun 15 2016, 10:23 AM
include/llvm/module.modulemap
123

Good point. It seems I have to add quite a few files (~50?) from IR explicitly to LLVM_Intrinsics_gen_IR. Is that acceptable?

v.g.vassilev removed rL LLVM as the repository for this revision.

It seems this is enough to disentangle the tablegen dependent headers from module LLVM_IR. Would that be the right way to express this?

rsmith accepted this revision.Jun 27 2016, 11:59 AM
rsmith edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2016, 11:59 AM