This is an archive of the discontinued LLVM Phabricator instance.

Enable index register memory constraints for inline ASM operands on SystemZ
ClosedPublic

Authored by colpell on Jun 10 2016, 1:43 PM.

Details

Summary

This enables use of the 'R' and 'T' memory constraints for inline ASM operands on SystemZ, which allow an index register as well as an immediate displacement. This patch includes corresponding documentation and test case updates.

As with the last patch of this kind, I moved the 'm' constraint to the most general case, which is now 'T' (base + 20-bit signed displacement + index register).

Diff Detail

Event Timeline

colpell updated this revision to Diff 60390.Jun 10 2016, 1:43 PM
colpell retitled this revision from to Enable index register memory constraints for inline ASM operands on SystemZ.
colpell updated this object.
colpell added a reviewer: uweigand.
colpell added a subscriber: llvm-commits.
uweigand accepted this revision.Jun 13 2016, 4:22 AM
uweigand edited edge metadata.

There's a typo in the documentation change, see inline annotations. Otherwise, LGTM.

docs/LangRef.rst
3598

The 20-bit immediates are *signed*, not unsigned like the 12-bit ones.

3600

Likewise.

This revision is now accepted and ready to land.Jun 13 2016, 4:22 AM
colpell updated this revision to Diff 60518.Jun 13 2016, 7:24 AM
colpell edited edge metadata.

Fix documentation typo (unsigned -> signed).

This revision was automatically updated to reflect the committed changes.