[cpu-detection] Add missing break statements in outer switches

[asbirlea]

Summary

Break on all switch cases for outer and inner switches.
Fixes fall-through bug introduced by r271726, having no functionality changed intended.

[sanjoy]

lgtm, but I don't think it is correct to state "No functionality changed." in the commit message.

[asbirlea]

Updated. Hope this explains it better.

lib/Support/Host.cpp

case 4:
     case 4: // Intel486 SL processor
     case 5: // IntelSX2 processors
     case 7: // Write-Back Enhanced IntelDX2 processors
     case 8: // IntelDX4 OverDrive processors, IntelDX4 processors
     default:
       *Type = INTEL_i486;
       break;
     }
+    break;
   case 5:
     switch (Model) {
     case 1: // Pentium OverDrive processor for Pentium processor (60, 66),
             // Pentium processors (60, 66)
     case 2: // Pentium OverDrive processor for Pentium processor (75, 90,
             // 100, 120, 133), Pentium processors (75, 90, 100, 120, 133,
             // 150, 166, 200)
     case 3: // Pentium OverDrive processors for Intel486 processor-based
             // systems
       *Type = INTEL_PENTIUM;
       break;
     case 4: // Pentium OverDrive processor with MMX technology for Pentium
             // processor (75, 90, 100, 120, 133), Pentium processor with
             // MMX technology (166, 200)
       *Type = INTEL_PENTIUM;
       *Subtype = INTEL_PENTIUM_MMX;
       break;
     default:
       *Type = INTEL_PENTIUM;
       break;
     }
+    break;
   case 6:
     switch (Model) {
     case 0x01: // Pentium Pro processor
       *Type = INTEL_PENTIUM_PRO;
       break;
     case 0x03: // Intel Pentium II OverDrive processor, Pentium II processor,
                // model 03
     case 0x05: // Pentium II processor, model 05, Pentium II Xeon processor,
default: // Unknown family 6 CPU, try to guess.
       }
       if (Features & (1 << FEATURE_MMX)) {
         *Type = INTEL_PENTIUM_II;
         break;
       }
       *Type = INTEL_PENTIUM_PRO;
       break;
     }
+    break;
   case 15: {
     switch (Model) {
     case 0: // Pentium 4 processor, Intel Xeon processor. All processors are
             // model 00h and manufactured using the 0.18 micron process.
     case 1: // Pentium 4 processor, Intel Xeon processor, Intel Xeon
             // processor MP, and Intel Celeron processor. All processors are
             // model 01h and manufactured using the 0.18 micron process.
     case 2: // Pentium 4 processor, Mobile Intel Pentium 4 processor - M,
case 6: // Pentium 4 processor, Pentium D processor, Pentium processor
           ((Features & (1 << FEATURE_EM64T)) ? INTEL_NOCONA : INTEL_PRESCOTT);
       break;
 
     default:
       *Type =
           ((Features & (1 << FEATURE_EM64T)) ? INTEL_X86_64 : INTEL_PENTIUM_IV);
       break;
     }
+    break;
   }
   default:
     break; /*"generic"*/
   }
 }
 
 static void getAMDProcessorTypeAndSubtype(unsigned int Family,
                                           unsigned int Model,
                                           unsigned int Features,
                                           unsigned *Type,
                                           unsigned *Subtype) {
   // FIXME: this poorly matches the generated SubtargetFeatureKV table.  There
   // appears to be no way to generate the wide variety of AMD-specific targets
   // from the information returned from CPUID.
   switch (Family) {
   case 4:
     *Type = AMD_i486;
+    break;
   case 5:
     *Type = AMDPENTIUM;
     switch (Model) {
     case 6:
     case 7:
       *Subtype = AMDPENTIUM_K6;
       break; // "k6"
     case 8:
       *Subtype = AMDPENTIUM_K62;
       break; // "k6-2"
     case 9:
     case 13:
       *Subtype = AMDPENTIUM_K63;
       break; // "k6-3"
     case 10:
       *Subtype = AMDPENTIUM_GEODE;
       break; // "geode"
-    default:
-      break;
     }
+    break;
   case 6:
     *Type = AMDATHLON;
     switch (Model) {
     case 4:
       *Subtype = AMDATHLON_TBIRD;
       break; // "athlon-tbird"
     case 6:
     case 7:
     case 8:
       *Subtype = AMDATHLON_MP;
       break; // "athlon-mp"
     case 10:
       *Subtype = AMDATHLON_XP;
       break; // "athlon-xp"
-    default:
-      break;
     }
+    break;
   case 15:
     *Type = AMDATHLON;
     if (Features & (1 << FEATURE_SSE3)) {
       *Subtype = AMDATHLON_K8SSE3;
       break; // "k8-sse3"
     }
     switch (Model) {
     case 1:
       *Subtype = AMDATHLON_OPTERON;
       break; // "opteron"
     case 5:
       *Subtype = AMDATHLON_FX;
       break; // "athlon-fx"; also opteron
     default:
       *Subtype = AMDATHLON_64;
       break; // "athlon64"
     }
+    break;
   case 16:
     *Type = AMDFAM10H; // "amdfam10"
     switch (Model) {
     case 2:
       *Subtype = AMDFAM10H_BARCELONA;
       break;
     case 4:
       *Subtype = AMDFAM10H_SHANGHAI;
       break;
     case 8:
       *Subtype = AMDFAM10H_ISTANBUL;
       break;
-    default:
-      break;
     }
+    break;
   case 20:
     *Type = AMDFAM14H;
     *Subtype = AMD_BTVER1;
     break; // "btver1";
   case 21:
     *Type = AMDFAM15H;
     if (!(Features &
           (1 << FEATURE_AVX))) { // If no AVX support, provide a sane fallback.