Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Few comments below.
lib/CodeGen/AsmPrinter/CodeViewDebug.cpp | ||
---|---|---|
484–487 |
| |
485 | I thought we wanted to have the index of FuncIdRecord, not the index of ProcedureRecord, right? |
Comment Actions
LGTM.
Only one comment (you might want to fix it in a follow up commit).
llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp | ||
---|---|---|
129 ↗ | (On Diff #59416) | Should not we return TypeIndex(0) in this case? |
I thought we wanted to have the index of FuncIdRecord, not the index of ProcedureRecord, right?
Check line 128.