Page MenuHomePhabricator

[RuntimeDyld] Support R_390_PC64 relocation type
ClosedPublic

Authored by bryanpkc on May 6 2016, 2:18 PM.

Details

Summary

When the MCJIT generates ELF code, some DWARF data requires 64-bit PC-relative relocation (R_390_PC64). This patch adds support for R_390_PC64 relocation to RuntimeDyld::resolveSystemZRelocation, to avoid an assertion failure.

Diff Detail

Event Timeline

bryanpkc updated this revision to Diff 56462.May 6 2016, 2:18 PM
bryanpkc retitled this revision from to [RuntimeDyld] Support R_390_PC64 relocation type.
bryanpkc updated this object.
bryanpkc added a reviewer: uweigand.
bryanpkc added a subscriber: llvm-commits.
uweigand accepted this revision.May 13 2016, 5:43 AM
uweigand edited edge metadata.

LGTM, thanks!

As an extra benefit, it would be great if you could also add test cases for the remaining relocation types that are already supported but don't have a test case yet ... (To be clear, this is not a requirement for committing this patch ...)

This revision is now accepted and ready to land.May 13 2016, 5:43 AM
bryanpkc closed this revision.May 13 2016, 10:29 AM

Thanks for the review. I will try to add some test cases in a future patch.