Page MenuHomePhabricator

DivergenceAnalysis: Fix crash with no return blocks
ClosedPublic

Authored by arsenm on Apr 29 2016, 11:21 AM.

Details

Summary

The post dominator tree does not have a root node in this case.

My original patch was still needed to fix this case

Diff Detail

Event Timeline

arsenm updated this revision to Diff 55633.Apr 29 2016, 11:21 AM
arsenm retitled this revision from to DivergenceAnalysis: Fix crash with no return blocks.
arsenm updated this object.
arsenm added a reviewer: jingyue.
arsenm added a subscriber: llvm-commits.
jingyue accepted this revision.Apr 29 2016, 5:50 PM
jingyue edited edge metadata.
jingyue added inline comments.
lib/Analysis/DivergenceAnalysis.cpp
146

The comment seems inaccurate. PDT.getNode(ThisBB) == nullptr means the function doesn't have an exit block or ThisBB doesn't reach any exit block of the function.

This revision is now accepted and ready to land.Apr 29 2016, 5:50 PM
arsenm closed this revision.May 9 2016, 10:03 AM

r268933