Details
Diff Detail
Event Timeline
This is very cool, thanks!
I've made several minor comments.
The patch does not apply to ToT (arc patch D19585 says 2 out of 14 hunks FAILED), for some reason, you may need to svn up / merge.
docs/LibFuzzer.rst | ||
---|---|---|
2 | For no particular reason I prefer libFuzzer. | |
96 | via a specific fuzzing entrypoint (aka "target function"); | |
97 | s/generations/generates | |
107–108 | I don't want to be this verbose. | |
307 | (unless you disable this by `-reload=0` command line flag) | |
320 | s/blocks/blocks or edges | |
330 | Remove outer () | |
377–380 | why not svn? | |
629–630 | While you are at it, remove this part (about function-scope statics). |
Sorry, forgot to merge up first. BTW, does Phabricator show whether the patch applies cleanly somewhere? I can't immediately see it in the UI.
docs/LibFuzzer.rst | ||
---|---|---|
2 | OK, but how do you want to handle sentences that start with the name -- capitalize or not? (At the moment I've left sentence starts as "LibFuzzer does xyz...") | |
377–380 | When I tried it, the current SVN tip wouldn't build, so I thought it safer to stick with a fixed release -- less vulnerable that way. |
For no particular reason I prefer libFuzzer.